Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rippling cli: Added flux build init command #7
rippling cli: Added flux build init command #7
Changes from 4 commits
430e8da
16920d5
8f2e73c
9556b29
8c1c627
34faa2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[best-practice]. Untyped 'type: ignore' or specific typed 'type: ignore' comments like 'attr-defined', 'method-assign', 'name-defined', 'operator' should be avoided as they can hide real issues.
💬 Reply with
/semgrep ignore <reason>
or triage in Semgrep Cloud Platform to ignore the finding created by development_avoid_type_ignore_error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this function called?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of initially including this part of command but looks like for pycharm run/debug configuration cannot be transferred so we will have to create .idea folder and copy the xml file inside the folder. I am planning to add this as part of run_server command as I am hoping that app-developer would have opened the project in pycharm. Since adding this file before in this command creates problem with pycharm settings which they pycharm does on project open