add check for shape title, set editingId (#140)

* add check for shape title, set editingId * move setEditingId to CustomEvent * close button works now, escape doesn't * 1.10.7
RoamJS · Aug 12, 2023 · fefee40 · fefee40
1 parent 49028c0
commit fefee40
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "query-builder",
-  "version": "1.10.6",
+  "version": "1.10.7",
   "description": "Introduces new user interfaces for building queries in Roam",
   "main": "./build/main.js",
   "author": {

diff --git a/src/components/TldrawCanvas.tsx b/src/components/TldrawCanvas.tsx
@@ -373,9 +373,8 @@ const LabelDialog = ({
         isOpen={isOpen}
         title={"Edit Discourse Node Label"}
         onClose={onCancelClick}
-        // Clicking the close button Wasn't working??
-        isCloseButtonShown={false}
         canOutsideClickClose
+        // Escape isn't working?
         canEscapeKeyClose
         autoFocus={false}
         className={"roamjs-discourse-playground-dialog"}
@@ -653,7 +652,10 @@ class DiscourseNodeUtil extends TLBoxUtil<DiscourseNodeShape> {
     }, [setLoaded, loaded, contentRef, shape.props.uid]);
     useEffect(() => {
       const listener = (e: CustomEvent) => {
-        if (e.detail === shape.id) setIsEditLabelOpen(true);
+        if (e.detail === shape.id) {
+          setIsEditLabelOpen(true);
+          this.app.setEditingId(shape.id);
+        }
       };
       document.body.addEventListener(
         "roamjs:query-builder:created-canvas-node",