Skip to content

Commit

Permalink
chore: fix lint error in platform
Browse files Browse the repository at this point in the history
  • Loading branch information
robertIsaac committed Dec 23, 2024
1 parent acf53f5 commit 14abe0b
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 32 deletions.
65 changes: 37 additions & 28 deletions libs/platform/eslint.config.js
Original file line number Diff line number Diff line change
@@ -1,34 +1,43 @@
const nx = require('@nx/eslint-plugin');
const baseConfig = require('../../eslint.config.js');
const overrides = require('../../eslint.overrides');

module.exports = [
...baseConfig,
...nx.configs['flat/angular'],
...nx.configs['flat/angular-template'],
{
files: ['**/*.ts'],
rules: {
'@angular-eslint/directive-selector': [
'error',
{
type: 'attribute',
prefix: 'app',
style: 'camelCase',
},
],
'@angular-eslint/component-selector': [
'error',
{
type: 'element',
prefix: 'app',
style: 'kebab-case',
},
],
...baseConfig,
...nx.configs['flat/angular'],
...nx.configs['flat/angular-template'],
...overrides,
{
files: ['**/*.ts'],
rules: {
'@angular-eslint/directive-selector': [
'error',
{
type: 'attribute',
prefix: 'fdp',
style: 'camelCase'
}
],
'@angular-eslint/component-selector': [
'error',
{
type: 'element',
prefix: 'fdp',
style: 'kebab-case'
}
]
}
},
},
{
files: ['**/*.html'],
// Override or add rules here
rules: {},
},
{
files: ['**/*.html'],
// Override or add rules here
rules: {
'@angular-eslint/template/label-has-associated-control': 'off',
'@angular-eslint/template/elements-content': 'off',
'@angular-eslint/template/interactive-supports-focus': 'off',
'@angular-eslint/template/click-events-have-key-events': 'off',
'@angular-eslint/template/valid-aria': 'off',
'@angular-eslint/template/role-has-required-aria': 'off'
}
}
];
Original file line number Diff line number Diff line change
Expand Up @@ -47,19 +47,19 @@ describe('Pipe: ConvertBytesPipe', () => {
});

it('should convert bytes to exabyte label', () => {
// eslint-disable-next-line @typescript-eslint/no-loss-of-precision
// eslint-disable-next-line no-loss-of-precision
const result = pipe.transform(4684567346346346345);
expect(result).toEqual('4.06 EB');
});

it('should convert bytes to zettabyte label', () => {
// eslint-disable-next-line @typescript-eslint/no-loss-of-precision
// eslint-disable-next-line no-loss-of-precision
const result = pipe.transform(5685685673452523537484);
expect(result).toEqual('4.82 ZB');
});

it('should convert bytes to yottabyte label', () => {
// eslint-disable-next-line @typescript-eslint/no-loss-of-precision
// eslint-disable-next-line no-loss-of-precision
const result = pipe.transform(5685685673452523537484568);
expect(result).toEqual('4.7 YB');
});
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/** Common properties for table dialogs */
// eslint-disable-next-line @typescript-eslint/no-empty-interface
// eslint-disable-next-line @typescript-eslint/no-empty-interface,@typescript-eslint/no-empty-object-type
export interface TableDialogCommonData {
// nothing here yet
}
1 change: 1 addition & 0 deletions libs/platform/table/table.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,7 @@ export class TableComponent<T = any>
readonly save = new EventEmitter<SaveRowsEvent<T>>();
/** Event fired when cancel button pressed. */
@Output()
// eslint-disable-next-line @angular-eslint/no-output-native
readonly cancel = new EventEmitter<void>();
/** Event emitted when table body being scrolled. */
@Output()
Expand Down

0 comments on commit 14abe0b

Please sign in to comment.