Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: During building block creation, add the 'sap.fe.macros' library to the 'manifest.json' if it is not already listed #2348

Merged
merged 9 commits into from
Sep 13, 2024

Conversation

815are
Copy link
Contributor

@815are 815are commented Sep 10, 2024

All changes related to creation of building blocks like Chart, Table, Filterbar.
Changes:

  1. If 'sap.fe.templates' or 'sap.fe.core' are not listed in manifest.json, then do not throw error about missing dependency;
  2. If 'sap.fe.macros' is not listed in manifest.json, then automatically add it to 'manifest.json' during building block creation;

add macros library on building block creation
Copy link

changeset-bot bot commented Sep 10, 2024

🦋 Changeset detected

Latest commit: 9a2811d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap-ux/fe-fpm-writer Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fe-fpm-cli Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@815are 815are added the fe-fpm-writer @sap-ux/fe-fpm-writer label Sep 10, 2024
@815are 815are changed the title feat: add macros library on building block creation feat: During building block creation, add the 'sap.fe.macros' library to the 'manifest.json' if it is not already listed Sep 11, 2024
@815are 815are marked this pull request as ready for review September 11, 2024 07:06
@815are 815are requested a review from a team as a code owner September 11, 2024 07:06
Copy link
Contributor

@AlinaGovoruhina AlinaGovoruhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is clear and understandable, unit test coverage good, changeset present

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes are clear and covered by tests
changset ✅

1 small suggestion

packages/fe-fpm-writer/src/building-block/index.ts Outdated Show resolved Hide resolved
packages/fe-fpm-writer/src/building-block/index.ts Outdated Show resolved Hide resolved
request comment
@815are 815are requested a review from devinea September 12, 2024 16:53
devinea
devinea previously approved these changes Sep 12, 2024
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. Re-approving.

examples
Copy link

sonarcloud bot commented Sep 12, 2024

Copy link
Contributor

@AlinaGovoruhina AlinaGovoruhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproving methods changed to async

@815are 815are merged commit 86bcf45 into main Sep 13, 2024
13 checks passed
@815are 815are deleted the feat/addMacrosLibOnBuildingBlockCreation branch September 13, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fe-fpm-writer @sap-ux/fe-fpm-writer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants