-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: During building block creation, add the 'sap.fe.macros' library to the 'manifest.json' if it is not already listed #2348
Conversation
add macros library on building block creation
🦋 Changeset detectedLatest commit: 9a2811d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is clear and understandable, unit test coverage good, changeset present
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes are clear and covered by tests
changset ✅
1 small suggestion
request comment
snapshot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. Re-approving.
examples
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reapproving methods changed to async
All changes related to creation of building blocks like
Chart
,Table
,Filterbar
.Changes:
manifest.json
, then do not throw error about missing dependency;manifest.json
, then automatically add it to 'manifest.json' during building block creation;