feat: CXSPA-4442 New components for email and personal info #17839
Conversation
|
|
|
Button is supposed to be align to the right consistent with the input right place according to the mockup. |
|
One question not very sure, don't we need to add our index to public_api.ts in components folder? |
I guess you want to align to left? |
In fact, it aligned and the padding is introduced by button.scss :( |
Be frankly, I don't know why we need it. I guess you are right. We need add it as other component does |
feature-libs/user/profile/components/new-user-profile/new-profile.component.spec.ts
Outdated
Show resolved
Hide resolved
|
please add accessibility test |
let me check whether it's in the scope |
|
|
Your e2e tests are already here. So I am curious why accessibility test is not. But it's ok for me to use another ticket that you mentioned to track it. |
| @@ -20,7 +20,7 @@ export function registerAndLogin() { | |||
| export function testUpdateEmailAndLogin() { | |||
| it('should update his email address and login', () => { | |||
| const newUid = generateMail(randomString(), true); | |||
| cy.get('cx-update-email').within(() => { | |||
| cy.get('cx-update-email, cx-my-new-account-v2-email').within(() => { | |||
There was a problem hiding this comment.
if v1 and v2 will exist at the same time, then does this change mean v1's tests will not pass in the future?
There was a problem hiding this comment.
this grammar means A or B in here.
| @@ -23,12 +23,19 @@ export function updateProfile(user?: SampleUser) { | |||
| ); | |||
| cy.get('[formcontrolname="lastName"]').should('have.value', user.lastName); | |||
| } | |||
| cy.get('.myaccount-enhancedUI-editButton') | |||
There was a problem hiding this comment.
maybe it's better to add new functions instead of modifying existing ones that for v1.
There was a problem hiding this comment.
two sides of the coin, modify/reuse code make it easily if we wanna change sth in the future
There was a problem hiding this comment.
I don't get the point. Does V1 also have this element myaccount-enhancedUI-editButton? Won't it cause any failure in V1‘s tests?
There was a problem hiding this comment.
if no this element, not click edit. ===> in V1, it loaded with edit model
if with this element. click edit ==> n V2, transfer to edit model.
Then we can reuse edit feature as it's totally same.
ATT. Below is how it works now
Update new video with new css on 18:12 21 Sept. Please check it again
2023-09-21_18-12-04.mp4