feat(backend): show error if NodeJS is not installed #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
docirl
commented
Oct 5, 2023
docirl
commented
- When a user does not have NodeJS installed locally this causes Yeoman UI not to work correctly (blank screen when opening the wizard)
- When Yeoman UI starts, and before it tries to search for or use a generator, check if node is installed locally by calling getProcessVersions
- if no node version is returned above, then display a native vscode error message to inform the user
idoprz
reviewed
Oct 8, 2023
packages/backend/package.json
Outdated
| @@ -185,6 +185,7 @@ | |||
| "dependencies": { | |||
| "@sap-devx/webview-rpc": "0.3.1", | |||
| "@sap-devx/yeoman-ui-types": "^1.12.2", | |||
| "@sap-ux/environment-check": "0.15.64", | |||
There was a problem hiding this comment.
Please do not add dependencies on @sap-ux we want the OSS to remain clean of such dependencies
There was a problem hiding this comment.
Ok, I've removed this and add the code to the npm util.
alex-gilin
requested changes
Oct 8, 2023
alex-gilin
requested changes
Oct 10, 2023
|
|
||
| it("should show an error message", () => { | ||
| windowMock.expects("showErrorMessage").withExactArgs(messages.nodejs_install_not_found); | ||
| void panel.loadWebviewPanel(); |
There was a problem hiding this comment.
Suggested change
| void panel.loadWebviewPanel(); | |
| await panel.loadWebviewPanel(); |
| Constants["IS_IN_BAS"] = false; | ||
| }); | ||
|
|
||
| it("should show an error message", () => { |
There was a problem hiding this comment.
Suggested change
| it("should show an error message", () => { | |
| it("should show an error message", async () => { |
alex-gilin
approved these changes
Oct 11, 2023
|
@idoprz I've removed the sap-ux dependency, can you re-review please? |
idoprz
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.