Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingest Roth24 Spectral types #482

Merged
merged 23 commits into from
Jul 26, 2024
Merged

Ingest Roth24 Spectral types #482

merged 23 commits into from
Jul 26, 2024

Conversation

rothermichaustin
Copy link
Contributor

@rothermichaustin rothermichaustin commented Mar 8, 2024 •
edited by kelle
Loading

Short description: Include what type of data being ingested and appropriate references.

Link to relevant issue: Closes #480

For data ingests:

  • includes script used for ingest
  • includes modified JSON files
  • Add new tests
  • Update the Versions table

@rothermichaustin rothermichaustin marked this pull request as draft March 8, 2024 16:24
kelle
kelle requested changes May 10, 2024
View reviewed changes
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function not quite right yet.

scripts/ingests/BYW_SpT2024.py Outdated Show resolved Hide resolved
@rothermichaustin rothermichaustin mentioned this pull request Jul 12, 2024
Closed
@kelle kelle mentioned this pull request Jul 12, 2024
Closed
Exu-112 and others added 13 commits July 16, 2024 13:12
@kelle
Copy link
Collaborator

kelle commented Jul 23, 2024 •
edited
Loading

Waiting on the completion of #539 which will touch ALL THE JSON files. This PR should just impact 87 JSON files.

@kelle kelle marked this pull request as ready for review July 26, 2024 19:09
kelle
kelle requested changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, we don't need the notebook as part of this PR. Please remove. Also, add the new Versions table so I can do a release!

@kelle kelle self-requested a review July 26, 2024 19:27
kelle
kelle approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING!!!

@kelle kelle merged commit 117aff1 into SIMPLE-AstroDB:main Jul 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelle kelle kelle approved these changes

Assignees

@rothermichaustin rothermichaustin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ingest Spectral Types from Roth24
3 participants
@rothermichaustin @kelle @Exu-112