-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(openchallenges): add EDAM terms SQL table and update Challenge.inputDataTypes
#2265
Conversation
2024 update:
|
apps/openchallenges/challenge-service/src/main/resources/db/challenge_data_edam.csv
Show resolved
Hide resolved
@vpchung Please update the information included in the first comment of this PR. |
Quality Gate passed for 'openchallenges-app'Issues Measures |
Quality Gate passed for 'openchallenges-challenge-service'Issues Measures |
Quality Gate passed for 'openchallenges-organization-service'Issues Measures |
Quality Gate passed for 'openchallenges-image-service'Issues Measures |
apps/openchallenges/challenge-service/src/main/resources/db/migration/V1.0.0__create_tables.sql
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the change to this file break the existing stack? Does the web app rely on this object?
The name and description of the object don't seem related. Shall the schema be renamed as EdamAnnotation?
Another question is whether we want to replace the existing data input object by an edam annotation object, or do we augment the existing data input data type object with an EDAM annotation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the change to this file break the existing stack? Does the web app rely on this object?
I tested the app, and no breakage was encountered. But it was a superficial test, so perhaps I didn't hit all of the edge cases.
Shall the schema be renamed as EdamAnnotation?
This makes sense to me.
Another question is whether we want to replace the existing data input object by an edam annotation object, or do we augment the existing data input data type object with an EDAM annotation?
I think this depends. Do we see the OC using other ontologies in the future? If so, I'd be inclined to keep it as SimpleChallengeInputData
(or ChallengeInputData
)
Challenge.inputDataTypes
Replaced by #2557 |
Changelog
edam_ontology_term
: a table consisting of EDAM ontology terms currently used to annotate challenges in the OC; includes parent classeschallenge_input_data_annotation
: a table mapping challenges to their EDAM annotation(s)References
Preview
API docs
edam_ontology_term
tablechallenge_input_data_annotation
table