Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): increase headline char limit to 120 #2330

Closed
wants to merge 5 commits into from

Conversation

vpchung
Copy link
Member

@vpchung vpchung commented Nov 7, 2023

Fixes #2320

Changelog

Backend

  • increase headline varchar limit from 80 to 120 in SQL table creation
  • update maxLength to 120 for ChallengeHeadline API spec
  • update headlines in CSV dump file

Frontend

  • decrease height of banner SVG's viewbox
  • decrease banner's height on challenge card - this will allow the card to remain at its current size
  • clamp headline at 3 lines (instead of 2)

Preview

API docs
Screenshot 2023-11-06 at 5 00 01 PM

Before
Screenshot 2023-11-06 at 4 49 02 PM

After
Screenshot 2023-11-06 at 4 48 42 PM

@vpchung vpchung self-assigned this Nov 7, 2023
@vpchung vpchung marked this pull request as ready for review November 7, 2023 01:23
@vpchung vpchung changed the title fix(openchallenges): increase headline char limit to 120 feat(openchallenges): increase headline char limit to 120 Nov 7, 2023
@vpchung
Copy link
Member Author

vpchung commented Nov 8, 2023

Feedback from the stand-up:

  • New design may have too much text
  • New banner size may not be easy to work with in the future
  • @tschaffter will try to generate new headlines up to 80 characters (whereas our current prompt is 10 words or less)

Closing PR now.

@vpchung vpchung closed this Nov 8, 2023
@vpchung vpchung deleted the headline-fix branch November 22, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Update the challenge card to display the entire headline
1 participant