Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(openchallenges): increase headline char limit to 120 #2330

Closed
wants to merge 5 commits into from
Closed

feat(openchallenges): increase headline char limit to 120 #2330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da05906
fix headlines; increase char limit to 120
vpchung Nov 6, 2023
eb233ff
increase `headline` varchar limit in table creation
vpchung Nov 6, 2023
8e97fa6
update API specs and docs
vpchung Nov 6, 2023
9afa82a
clamp headline at 3 lines instead of 2
vpchung Nov 7, 2023
d6ca020
decrease height of banner on card
vpchung Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
348 changes: 174 additions & 174 deletions apps/openchallenges/challenge-service/src/main/resources/db/challenges.csv
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...penchallenges/challenge-service/src/main/resources/db/migration/V1.0.0__create_tables.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ CREATE TABLE `challenge`
`id` bigint(20) NOT NULL AUTO_INCREMENT,
`slug` varchar(255) NOT NULL,
`name` varchar(255) DEFAULT NULL,
`headline` varchar(80),
`headline` varchar(120),
`description` varchar(1000) NOT NULL,
`avatar_url` varchar(255),
`website_url` varchar(255) NOT NULL,
Expand Down
2 changes: 1 addition & 1 deletion libs/openchallenges/api-description/build/challenge.openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,7 +384,7 @@ components:
description: The headline of the challenge.
type: string
minLength: 0
maxLength: 80
maxLength: 120
example: Example challenge headline
ChallengeDescription:
description: The description of the challenge.
Expand Down
2 changes: 1 addition & 1 deletion libs/openchallenges/api-description/build/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ components:
description: The headline of the challenge.
type: string
minLength: 0
maxLength: 80
maxLength: 120
example: Example challenge headline
ChallengeDescription:
description: The description of the challenge.
Expand Down
2 changes: 1 addition & 1 deletion libs/openchallenges/api-description/src/components/schemas/ChallengeHeadline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
description: The headline of the challenge.
type: string
minLength: 0
maxLength: 80
maxLength: 120
example: Example challenge headline
2 changes: 1 addition & 1 deletion libs/openchallenges/assets/src/assets/images/banner-default.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 1 addition & 2 deletions libs/openchallenges/styles/src/lib/_general.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ table {
}
.card-banner {
width: 100%;
height: 130px;
display: flex;
align-items: flex-start;
}
Expand All @@ -297,7 +296,7 @@ table {
@include line-clamp(2);
}
.mat-caption {
@include line-clamp(2);
@include line-clamp(3);
}
.card-body {
width: 100%;
Expand Down
4 changes: 2 additions & 2 deletions libs/openchallenges/ui/src/lib/challenge-card/challenge-card.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
min-height: 190px;
}
.card-banner {
height: 100%;
height: 57px;
}
.card-status {
div:first-child {
Expand All @@ -36,5 +36,5 @@
display: flex;
align-items: center;
flex: 1;
@include general.line-clamp(2);
@include general.line-clamp(1);
}