Avoid race conditions on patch replenishment #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves two critical edge cases with patch replenishment:
WithLatestFrom
to get the current patch threshold. This means patch threshold transitions had to wait for a sample arriving from the wheel. This created a race between the block transition and local patch transition notifications. Changing the operator toCombineLatest
ensures patch transition to NaN is synchronized and strictly preceding block transition.