feat(block_analysis): add table for BlockForagingBout #432
Conversation
| bout_start: datetime(6) | ||
| --- | ||
| bout_end: datetime(6) | ||
| bout_duration: float # (seconds) |
There was a problem hiding this comment.
I'm happy to remove duration here and in the foraging_bouts function as it is trivial to recompute from the start and end times
There was a problem hiding this comment.
So I guess the docstring and comments in that function, and any code computing the durations should be updated as welll?
There was a problem hiding this comment.
Ah, that's because I saw the bout_durations being computed in the function but then not used at all. I thought it was meant to be added to the result dataframe.
I think it's convenient to add in the table, but we can omit and compute on the fly if needed
There was a problem hiding this comment.
Oh, I now see that you mentioned this in #427, sorry I missed this
|
Cool, looks good, thanks! |
jkbhagatio
merged commit 5dacb45
into
SainsburyWellcomeCentre:datajoint_pipeline
@jkbhagatio , I also rearrange
get_threshold_associated_pelletsslightly to add more checks for empty dataframes.