Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame extraction in the cluster using entry points #88

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 20, 2023

Right now we manually edit the frame extraction script for the different jobs. With this PR we instead keep the bash script intact, and pass any required parameters as command line arguments.

Specifically, we would pass a config.json file that we would read and print to the logs. This way we keep track of what input parameters we passed but the bash script is not edited every time.

If the bash script is intact, then testing should be easier. I had a look at a few options for unit testing bash scripts:

  • bats seems like a very nice tool for this. IIUC, it can be run in CI too.
  • bach is another option, apparently all tests are --dry-run by default.
    • I don't fully get what they mean with "Because that unit tests should verify the behavior of bash scripts, not test commands."
    • I find the syntax a bit less user-friendly than bats (e.g., one test case in Bach is made up of two functions: one for running tests and one for asserting), but it may be a matter of familiarising oneself with it.
    • a blogpost on bach
  • shunit2 is an alternative but seems less actively maintained (last release 2020) and the syntax seems a bit more cumbersome.

Any feedback or comments more than welcome!

@sfmig sfmig changed the title Frame extraction w entry points Frame extraction in the cluster using entry points Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant