Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create reusable heading components #1239

Merged
merged 8 commits into from
Jul 11, 2024
Merged

Conversation

robines
Copy link
Member

@robines robines commented Jun 29, 2024

The first header is 2.25rem (36px) on desktop displays only, anything smaller and it's 1.875rem (30px). This is because 36px can look a bit too big on smaller displays.

Created issue #1240 for applying usage of the components across the project.

Screenshot

image

@robines robines self-assigned this Jun 29, 2024
@robines robines requested a review from Snorre98 as a code owner June 29, 2024 12:31
Copy link
Contributor

@magsyg magsyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mulig å kanskje omgjøre til en felles header component? så slipper man å importere forskjellige H#

@robines
Copy link
Member Author

robines commented Jul 1, 2024

@magsyg For tree-shakingen sin del så syns jeg ikke det

Copy link
Contributor

@Snorre98 Snorre98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Se kommentar

@robines robines merged commit f9f2412 into master Jul 11, 2024
5 checks passed
@robines robines deleted the robin/create-header-components branch July 11, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants