Pin dask <2024.9 #6255
Merged
Pin dask <2024.9 #6255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6255 +/- ##
==========================================
+ Coverage 89.81% 89.83% +0.01%
==========================================
Files 88 88
Lines 23347 23347
Branches 4344 4344
==========================================
+ Hits 20970 20974 +4
+ Misses 1649 1646 -3
+ Partials 728 727 -1 ☔ View full report in Codecov by Sentry. |
trexfeathers
requested changes
Dec 13, 2024
We have an outstanding action to get the lockfiles working again, so that's going to get in your way: #6215 (comment) It's not a big thing, perhaps you and I could get that over the line this afternoon? |
…ask_slicing_bug * origin/pin_dask_slicing_bug: `date_microseconds` FUTURE flag (SciTools#6260) [pre-commit.ci] pre-commit autoupdate (SciTools#6259) Remove freepik.com link due to linkcheck breakage (SciTools#6261)
github-actions
bot
added
the
benchmark_this
|
The doctest failure: I had a PR merged-and-released on Dask, which allowed me to remove this workaround: If we're using an older version of Dask then the above workaround needs to go back in. |
trexfeathers
requested changes
Dec 17, 2024
There was a problem hiding this comment.
- We should announce the pin and the reason in a What's New entry.
- Please can we have a new Iris issue that records the need to unpin in future.
Unpin dask when slicing bug is fixed #6264
⏱️ Performance Benchmark Report: b7a65b4Performance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: eeb1290Performance shiftsFull benchmark resultsGenerated by GHA run |
trexfeathers
approved these changes
Dec 18, 2024
⏱️ Performance Benchmark Report: 84cf32dPerformance shiftsFull benchmark resultsGenerated by GHA run |
⏱️ Performance Benchmark Report: 64abf74Performance shiftsFull benchmark resultsGenerated by GHA run |
ESadek-MO
pushed a commit
to ESadek-MO/iris
that referenced
this pull request
Dec 19, 2024
* pin dask <2024.9 * update lockfiles * update for pypi * add whatsnew, fix tests * skip failing doctests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Addresses #6251.
Note: it may be worth also adding a test for the bug encountered in #6251.This bug can be replicated without Iris, so this probably doesn't fall under our jurisdiction to test for.TODO: update the lockfiles.