Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove freepik.com link due to linkcheck breakage #6261

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

trexfeathers
Copy link
Contributor

🚀 Pull Request

Description


Consult Iris pull request check list


Add any of the below labels to trigger actions on this PR:

  • benchmark_this Request that this pull request be benchmarked to check if it introduces performance shifts

docs/src/conf.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (0fdedb4) to head (1b791ea).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6261   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files          88       88           
  Lines       23315    23315           
  Branches     4338     4338           
=======================================
  Hits        20945    20945           
  Misses       1644     1644           
  Partials      726      726           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trexfeathers
Copy link
Contributor Author

@ukmo-ccbunney thanks for volunteering your time, this should be a quick one! I decided the link didn't deliver any value so it wasn't worth pursuing and just removed it instead.

@trexfeathers trexfeathers changed the title Add freepik.com to linkcheck ignore Remove freepik.com link due to linkcheck breakage Dec 17, 2024
Copy link
Contributor

@ukmo-ccbunney ukmo-ccbunney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd how the link ignore didn't work, that was going to be my suggestion until I saw you already tried it.

I agree that we can just remove it, especially as it is blocking other work.

@ukmo-ccbunney ukmo-ccbunney merged commit bd1ae15 into SciTools:main Dec 17, 2024
21 checks passed
@trexfeathers
Copy link
Contributor Author

Thanks @ukmo-ccbunney!

stephenworsley added a commit to stephenworsley/iris that referenced this pull request Dec 17, 2024
…ask_slicing_bug

* origin/pin_dask_slicing_bug:
  `date_microseconds` FUTURE flag (SciTools#6260)
  [pre-commit.ci] pre-commit autoupdate (SciTools#6259)
  Remove freepik.com link due to linkcheck breakage (SciTools#6261)
ESadek-MO pushed a commit to ESadek-MO/iris that referenced this pull request Dec 19, 2024
@pp-mo pp-mo mentioned this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants