Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup test names / scopelint fix #22

Merged
merged 10 commits into from
Jan 8, 2024
Merged

Cleanup test names / scopelint fix #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
26bf040
Cleanup test names / scopelint fix
jferas Dec 11, 2023
9a29bea
Cleanup test names to best practices
jferas Dec 12, 2023
679852d
Added test for timelock pausing/unpausing
jferas Dec 12, 2023
8b9f7d6
Added 2 missing Alpha tests and removed commented out code
jferas Dec 13, 2023
3b432a7
Moved test functions from RadworksGovernorAlpha.t.sol to RadworksGove…
jferas Dec 13, 2023
9963f47
Updated helper name to _assumeNotTimelock after rebase
jferas Dec 20, 2023
1076a1b
Added assume for pauser test that fuzzed pauser not already in pauser…
jferas Dec 20, 2023
e76dd45
Removed @dev comment
jferas Dec 20, 2023
dca5641
Removed on-chain test invocations for now (till deployment)
jferas Dec 21, 2023
b0e85b2
Removed unneeded newline
jferas Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/Constants.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ contract Constants {
address constant TIMELOCK = 0x8dA8f82d2BbDd896822de723F55D6EdF416130ba;
address constant DRIPS = 0xd0Dd053392db676D57317CD4fe96Fc2cCf42D0b4;

// TODO: resolve the list of large delegates with tallyaddress
address constant PROPOSER = 0x464D78a5C97A2E2E9839C353ee9B6d4204c90B0b; // cloudhead.eth

address constant USDC_ADDRESS = 0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eB48;
Expand All @@ -16,8 +15,8 @@ contract Constants {
address constant MTV_ADDRESS = 0x6226e00bCAc68b0Fe55583B90A1d727C14fAB77f;
uint256 constant MAX_REASONABLE_TIME_PERIOD = 302_400; // 6 weeks assume a 12 sec block time

// we have not yet deployed the Radworks Bravo Governor
address constant DEPLOYED_BRAVO_GOVERNOR = 0x1111111111111111111111111111111111111111;
// we have not yet deployed the Radworks Bravo Governor (will be replaced with deployed address)
address constant DEPLOYED_BRAVO_GOVERNOR = address(0x0);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(arbitrary comment)

  • When looking at the Scopelint spec of PoolTogether I noticed a couple test cases were missing in Radworks.

│ ├── Old Governor Cannot Send E T H After Proposal Succeeds
│ ├── Old Governor Sends Token After Proposal Is Defeated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done: 2d0828d


uint256 constant QUORUM = 4_000_000e18;
}
200 changes: 0 additions & 200 deletions test/RadworksDripsGovernance.t.sol
View file
Open in desktop

This file was deleted.

Loading
Loading