Cleanup test names / scopelint fix #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2023
Merged
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
alexkeating
reviewed
Dec 12, 2023
| @@ -17,7 +16,8 @@ contract Constants { | |||
| uint256 constant MAX_REASONABLE_TIME_PERIOD = 302_400; // 6 weeks assume a 12 sec block time | |||
|
|
|||
| // we have not yet deployed the Radworks Bravo Governor | |||
| address constant DEPLOYED_BRAVO_GOVERNOR = 0x1111111111111111111111111111111111111111; | |||
| // @dev: this is a placeholder address and will be replaced with the deployed address | |||
| address constant DEPLOYED_BRAVO_GOVERNOR = address(0x0); | |||
There was a problem hiding this comment.
(arbitrary comment)
- When looking at the Scopelint spec of PoolTogether I noticed a couple test cases were missing in Radworks.
│ ├── Old Governor Cannot Send E T H After Proposal Succeeds
│ ├── Old Governor Sends Token After Proposal Is Defeated
jferas
force-pushed
the
test-cleanup-scopelint-spec-fix
branch
2 times, most recently
from
360bb5b
to
d2f8877
Compare
alexkeating
reviewed
Dec 13, 2023
test/RadworksGovernor.t.sol
Outdated
| } | ||
|
|
||
| function testFuzz_CanGrantPauserOnDrips(address _newPauser) public { | ||
| // assummeNotTimelock(_newPauser); |
|
This commit e41b463 moved test functions from RadworksGovernorAlpha.t.sol (and deleted it) into RadworksGovernor.t.sol so that the test functions would be reported on by |
jferas
force-pushed
the
drips-admin-tests
branch
from
cfabece
to
ec11571
Compare
jferas
force-pushed
the
test-cleanup-scopelint-spec-fix
branch
from
e41b463
to
917826e
Compare
jferas
force-pushed
the
drips-admin-tests
branch
from
ec11571
to
79efaea
Compare
jferas
force-pushed
the
test-cleanup-scopelint-spec-fix
branch
from
917826e
to
bf9ac33
Compare
alexkeating
approved these changes
Dec 21, 2023
jferas
force-pushed
the
drips-admin-tests
branch
from
79efaea
to
7ffeb0a
Compare
jferas
force-pushed
the
test-cleanup-scopelint-spec-fix
branch
2 times, most recently
from
5321783
to
f20777f
Compare
wildmolasses
approved these changes
Jan 8, 2024
…rnor.t.sol for scopelint compatibility
jferas
force-pushed
the
test-cleanup-scopelint-spec-fix
branch
from
f20777f
to
b0e85b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up test contracts and how they are organized and named for better compatibility with "scopelint spec" command.