Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-6538 contract and tests #5

Merged
merged 38 commits into from
Feb 6, 2024
Merged

Update ERC-6538 contract and tests #5

merged 38 commits into from
Feb 6, 2024

Commits on Dec 14, 2023

  1. Update contract and tests to use address for the registrant

    @garyghayrat
    garyghayrat committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    90956d3 View commit details
    Browse the repository at this point in the history

  2. Add salt to deploy script so it uses Create2

    @garyghayrat
    garyghayrat committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    cbb2926 View commit details
    Browse the repository at this point in the history

  3. Format using scopelint

    @garyghayrat
    garyghayrat committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    eec3747 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Add passing signature verification test with oz's SignatureChecker

    @garyghayrat
    garyghayrat committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    b475760 View commit details
    Browse the repository at this point in the history

  2. Take out OZ SignatureChecker dependency

    @garyghayrat
    garyghayrat committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    1031061 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Add nonce tracking

    @garyghayrat
    garyghayrat committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e71c38b View commit details
    Browse the repository at this point in the history

  2. Require contract address matches precomputed address

    @garyghayrat
    garyghayrat committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    6cb358a View commit details
    Browse the repository at this point in the history

  3. Support EIP-712

    @garyghayrat
    garyghayrat committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    12eedad View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Add ERC1271MockContract and test

    @garyghayrat
    garyghayrat committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    606e51c View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Change contract license to MIT

    @garyghayrat
    garyghayrat committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    835c2c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Add natspec and incrementNonce method

    @garyghayrat
    garyghayrat committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    4460b6e View commit details
    Browse the repository at this point in the history

  2. Update Interface solidity version

    @garyghayrat
    garyghayrat committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    7284ded View commit details
    Browse the repository at this point in the history

  3. Update natspec

    @garyghayrat
    garyghayrat committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    aa80734 View commit details
    Browse the repository at this point in the history

  4. clean up comment

    @garyghayrat
    garyghayrat committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c537910 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2024

  1. Update documentation

    @garyghayrat
    garyghayrat committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    12039aa View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. Add deploy script test

    @garyghayrat
    garyghayrat committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    7997644 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Update comments

    @garyghayrat
    garyghayrat committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9372812 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Simplify the contract

    @garyghayrat
    garyghayrat committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    b2af4c6 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Simplify ERC712,1271 signature verification process

    @garyghayrat
    garyghayrat committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    a5898bd View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2024

  1. Update comments and remove unused function

    @garyghayrat
    garyghayrat committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    2384caa View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Add incrementNonce and recompute domain seperator if chain forks

    @garyghayrat
    garyghayrat committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    075b13d View commit details
    Browse the repository at this point in the history

  2. Rename tests

    @garyghayrat
    garyghayrat committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    d59b26f View commit details
    Browse the repository at this point in the history

  3. Increase test coverage

    @garyghayrat
    garyghayrat committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    f10e5dd View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Style update and remove v,r,s

    @garyghayrat
    garyghayrat committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    7cfeddc View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Fix typeHash usage

    @garyghayrat
    garyghayrat committed Jan 25, 2024
    Configuration menu
    Copy the full SHA
    d8140ae View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Add custom error

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    bce18d4 View commit details
    Browse the repository at this point in the history

  2. Add standalone type hash definition and remove regitrant from it

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a9b7db1 View commit details
    Browse the repository at this point in the history

  3. Change some @dev to @notice

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    bf34791 View commit details
    Browse the repository at this point in the history

  4. Remove 5564 interface inheritence

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    0c32536 View commit details
    Browse the repository at this point in the history

  5. Update tests to improve scopelint spec

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a5b3e4d View commit details
    Browse the repository at this point in the history

  6. Update IERC6538

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    aa7965e View commit details
    Browse the repository at this point in the history

  7. Add action to check interface is in sync w/ contract

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e403dce View commit details
    Browse the repository at this point in the history

  8. Set up Go in CI

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e5c6598 View commit details
    Browse the repository at this point in the history

  9. Extract abi part to compare and update IERC6538

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    07861cd View commit details
    Browse the repository at this point in the history

  10. Fix CI for IERC6538Registry check

    @garyghayrat
    garyghayrat committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    26ffbf7 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Update test names to be verbose for scopelint spec

    @garyghayrat
    garyghayrat committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3a5aa7c View commit details
    Browse the repository at this point in the history

  2. Update CI to [email protected]

    @garyghayrat
    garyghayrat committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    7e34641 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Correct the registry domain separator and refactor test suite 

    * Test internal variable initialization in registry constructor tests
* Improvements to domain separator test
* Improvements to the RegisteryKeys tests
* Naming improvements to registerKeysOnBehalf tests
* Update test imports and remove duplicated import
* Refactor signature test helpers for test simplicity
* Simplify mock contract for ERC1271 signatures
* Remove redundant test and add missing ones for register on behalf
* Minor cleanup to increment nonce test
* Update the EIP712Domain separator to match the spec
* Simplify Announcer test names
* Use `vm.expectRevert("")` instead of `vm.expectRevert()`
    @apbendi
    apbendi committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    df75e3e View commit details
    Browse the repository at this point in the history