Update ERC-6538 contract and tests #5
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
garyghayrat
changed the title
|
@garyghayrat Can you request me as a reviewer so I remember to review this? I think with this comment you now should be able to |
Hmm, still don't see you in the reviewers list |
There was a problem hiding this comment.
Hey @garyghayrat, overall this is looking way better! I did leave some questions, the most important of which is related to the type hash. Thanks!
There was a problem hiding this comment.
Thanks for your patience @garyghayrat. More comments. But we are getting there.
There was a problem hiding this comment.
More comments @garyghayrat, I promise we're getting close and I'm not trying to drive you crazy 🙈
* Test internal variable initialization in registry constructor tests
* Improvements to domain separator test
* Improvements to the RegisteryKeys tests
* Naming improvements to registerKeysOnBehalf tests
* Update test imports and remove duplicated import
* Refactor signature test helpers for test simplicity
* Simplify mock contract for ERC1271 signatures
* Remove redundant test and add missing ones for register on behalf
* Minor cleanup to increment nonce test
* Update the EIP712Domain separator to match the spec
* Simplify Announcer test names
* Use `vm.expectRevert("")` instead of `vm.expectRevert()`
apbendi
force-pushed
the
erc-6538-use-address-only
branch
from
471d3be
to
df75e3e
Compare
|
Coverage after merging erc-6538-use-address-only into main will be
Coverage Report
|
|||||||||||||||||||||||||
No description provided.