-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general scripting fixes #15621
general scripting fixes #15621
Conversation
guh..
i should stop coding in the fucking browser:fire:
correct origin and error message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff regarding hscript files
callOnHScript
has the broken old error message, and initHScript
doesn't destroy the script and/or remove it from hscriptArray
as the catch is never triggered there
Also I would probably only use addTextToDebug
for errorCaught because using runHaxeCode
outside of any callbacks doesn't print an error because of either lastCalledScript
not being set or the last called script not enabling luaDebugMode
superseded by #15891 |
parse(true)
when the code is initialized again! ive also attempted to fix return values without a provided function (ex.runHaxeCode("return 1234;")
should properly return 1234)Type
,Reflect
,File
,FileSystem
) to add to the default imports as they are commonly usedtest script to verify everything works as intended: