-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general scripting improvements (the sequel) #15891
Open
inky03
wants to merge
19
commits into
ShadowMario:main
Choose a base branch
from
inky03:script-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+274
−230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hello again github browser
bye alert (also init hscript module)
arrays with instance arguments and little improvements
removed pr wokrflow
shout outs to LarryFrosty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements all proposed hscript fixes in #15621, and has other additional changes:
run(?functionName, ?functionArguments)
, similar toexecuteFunction
previously but also allows the main body to be executed if no function name is providedthe trace function has also been added to print a message with the line number (highlighted with the cyan color)
to differentiate them from the rest of the errors and very much like the new fatal hscript errors, they're highlighted in dark red
fixed in another pr (which has been merged)Paths.font
has been fixed? changed an incorrect variable when getting the font path, sosetTextFont
in lua API should work correctly nowcode example:
callMethod
,callMethodFromClass
andcreateInstance
now allow you to not pass the arguments array at all; no more {''} (ex.callMethod('openPauseMenu', {''})
->callMethod('openPauseMenu')
)HSCRIPT_ALLOWED
is disabled, trying to use hscript related API functions in lua should now actually just show a warning (this was accounted for already, but did not work because the hscript class wasn't even created if the flag wasn't defined)