Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploying Preprocessor Healthchecks #936

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

shahdyousefak
Copy link
Contributor

@shahdyousefak shahdyousefak commented Dec 20, 2024

Please ensure you've followed the checklist and provide all the required information before requesting a review.
If you do not have everything applicable to your PR, it will not be reviewed!
If you don't know what something is or if it applies to you, ask!

Don't delete below this line.


Since we're deploying to production, we should move the healthchecks out of test-docker-compose.yml to their corresponding dockerfiles. In this PR, I add the healthchecks to the Dockerfiles of grouping, ocr, and semantic segmentation preprocessors.

Required Information

  • I referenced the issue addressed in this PR.
  • I described the changes made and how these address the issue.
  • I described how I tested these changes. -> rebuilt the containers with the updated Dockerfiles; health status reflecting accordingly.

Coding/Commit Requirements

  • I followed applicable coding standards where appropriate (e.g., PEP8)
  • I have not committed any models or other large files.

New Component Checklist (mandatory for new microservices)

  • I added an entry to docker-compose.yml and build.yml.
  • I created A CI workflow under .github/workflows.
  • I have created a README.md file that describes what the component does and what it depends on (other microservices, ML models, etc.).

OR

  • I have not added a new component in this PR.

@shahdyousefak shahdyousefak requested a review from jeffbl December 20, 2024 16:27
@jeffbl
Copy link
Member

jeffbl commented Dec 20, 2024

@shahdyousefak Please add description of change (what is this for?) in initial comment, and how it was tested.

@jeffbl jeffbl assigned jeffbl and shahdyousefak and unassigned jeffbl Dec 20, 2024
@shahdyousefak shahdyousefak changed the title Moving the healthchecks out of test-docker-compose.yml Deploying Preprocessor Healthchecks Dec 20, 2024
@jeffbl jeffbl assigned shahdyousefak and jeffbl and unassigned jeffbl and shahdyousefak Dec 20, 2024
Copy link
Member

@jeffbl jeffbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, merge when ready

@jeffbl jeffbl assigned shahdyousefak and unassigned jeffbl Dec 20, 2024
@shahdyousefak shahdyousefak merged commit 114140f into main Dec 20, 2024
6 checks passed
@shahdyousefak shahdyousefak deleted the moving-healthchecks branch December 20, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants