Implement translation for PM_ASSOC_SPLAT_NODE
#225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egiurleo
commented
Aug 29, 2024
|
|
||
| # with other hash keys | ||
| { a: 1, **foo } | ||
| { **foo, a: 1 } |
There was a problem hiding this comment.
Any other cases to be mindful of here? The other hash key/value pairs technically don't impact the assoc splat node, but I figured it would be reassuring to test it in a couple more contexts.
There was a problem hiding this comment.
How about anonymous ones, in method params?
def forwarder(**)
forwardee(**)
endThere was a problem hiding this comment.
Will handle this one separately. Issue here: #231
amomchilov
approved these changes
Aug 30, 2024
|
|
||
| # with other hash keys | ||
| { a: 1, **foo } | ||
| { **foo, a: 1 } |
There was a problem hiding this comment.
How about anonymous ones, in method params?
def forwarder(**)
forwardee(**)
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45
Test plan
See included automated tests.