RHP4 spec changes #219
Merged
RHP4 spec changes #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types,consensus: Add Capacity field to V2FileContract
| @@ -715,6 +715,8 @@ func validateV2FileContracts(ms *MidState, txn types.V2Transaction) error { | |||
|
|
|||
| validateContract := func(fc types.V2FileContract, renewal bool) error { | |||
| switch { | |||
| case fc.Filesize > fc.Capacity: | |||
There was a problem hiding this comment.
Could it be that we are missing fc.Filesize % SectorSize == 0 checks? Same for capacity?
There was a problem hiding this comment.
SectorSize is not a consensus concept, only an RHP one.
There was a problem hiding this comment.
@lukechampine what about SegmentSize?
Co-authored-by: Christopher Schinnerl <[email protected]>
ChrisSchinnerl
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #218
Requires #220