feat: update page titles for dashboards and alerts #6706
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 86a74a6 in 36 seconds
More details
- Looked at
29lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. frontend/src/pages/AlertDetails/AlertDetails.tsx:84
- Draft comment:
Consider extracting the document title update logic into a reusable function to adhere to the DRY principle. This logic is also present inDashboardPage.tsx. - Reason this comment was not posted:
Confidence changes required:50%
The document title update logic is repeated in both files. It would be better to extract this logic into a reusable function to adhere to the DRY principle.
2. frontend/src/pages/NewDashboard/DashboardPage.tsx:21
- Draft comment:
Avoid using inline styles for setting document titles. Consider using a React effect hook to manage side effects like updating the document title. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_UBLf4YItn1uZTHvi
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -80,6 +80,9 @@ function AlertDetails(): JSX.Element { | |||
| alertDetailsResponse, | |||
| } = useGetAlertRuleDetails(); | |||
|
|
|||
| const alertTitle = alertDetailsResponse?.payload?.data.alert; | |||
| document.title = alertTitle || document.title; | |||
There was a problem hiding this comment.
Avoid using inline styles for setting document titles. Consider using a React effect hook to manage side effects like updating the document title.
There was a problem hiding this comment.
Updated the titles in useEffect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The titles of dashboards and alerts are updated to their names.
Screenshots
Important
Update
document.titleinAlertDetails.tsxandDashboardPage.tsxto reflect alert and dashboard names.document.titleinAlertDetails.tsxto the alert name fromalertDetailsResponse.document.titleinDashboardPage.tsxto the dashboard name fromdashboardResponse.AlertDetails.tsxDashboardPage.tsxThis description was created by
for 86a74a6. It will automatically update as commits are pushed.