Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update page titles for dashboards and alerts #6706

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −1
Open

feat: update page titles for dashboards and alerts #6706

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86a74a6
feat: update page titles for dashboards and alerts
nishantharcot Dec 24, 2024
f418a88
fix: page titles update in useEffect
nishantharcot Dec 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions frontend/src/pages/AlertDetails/AlertDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ function AlertDetails(): JSX.Element {
alertDetailsResponse,
} = useGetAlertRuleDetails();

const alertTitle = alertDetailsResponse?.payload?.data.alert;
document.title = alertTitle || document.title;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using inline styles for setting document titles. Consider using a React effect hook to manage side effects like updating the document title.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the titles in useEffect.


if (
isError ||
!isValidRuleId ||
Expand Down
3 changes: 3 additions & 0 deletions frontend/src/pages/NewDashboard/DashboardPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ function DashboardPage(): JSX.Element {
(dashboardResponse?.error as AxiosError)?.response?.data?.errorType
: 'Something went wrong';

const dashboardTitle = dashboardResponse.data?.data.title;
document.title = dashboardTitle || document.title;

if (isError && !isFetching && errorMessage === ErrorType.NotFound) {
return <NotFound />;
}
Expand Down