[Next.js] Introduce nextjs-xmcloud Initializer Template
#1653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplate (driven by prompt / --xmcloud CLI option)
…(GraphQLSiteInfoService)
...ges/create-sitecore-jss/src/templates/nextjs-xmcloud/scripts/config/plugins/edge-platform.ts
Outdated
Show resolved
Hide resolved
illiakovalenko
approved these changes
Nov 7, 2023
7 tasks
art-alexeyenko
pushed a commit
that referenced
this pull request
Nov 8, 2023
* rename nextjs-personalize -> nextjs-xmcloud. move feaas and BYOC here. * Move Sitecore Edge Platform / conext related items to nextjs-xmcloud * Repurpose nextjs-personalize -> nextjs-xmcloud initializer "system" template (driven by prompt / --xmcloud CLI option) * Moved skipping of site information fetch on XM Cloud to base package (GraphQLSiteInfoService) * CHANGELOG update * fix scaffold samples * removed <BYOC/> from sxa Layout.tsx * fix for PR comment (cherry picked from commit 19f5c22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Introduced a
nextjs-xmcloudinitializer “system” template which will contain all XM Cloud base features, including Personalize, FEaaS, BYOC, Edge Proxy and Context support. Moved everything related to these features fromnextjsbase template tonextjs-xmcloud. This keeps the basenextjstemplate free of XM Cloud-only artifacts for SXP.Note: this replaces the previous
nextjs-personalizetemplate.The following changes are made to the JSS initializer (
create-sitecore-jss) flow:nextjsis the selected framework, a new prompt shows:nextjs-xmcloudis added to template listnextjs-styleguide(SXP and XMC)nextjs-styleguide-tracking(SXP)nextjs-sxa(SXP and XMC)nextjs-multisite(SXP and XMC)-xmcloudto control prompt via CLIThis PR also includes a follow-up to #1649, moving the skipping of site information fetch on XM Cloud to the
GraphQLSiteInfoService.Testing Details
Types of changes