Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Set FETCH_WITH.REST to 'REST' instead of 'Rest' #1927

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[sitecore-jss] Set FETCH_WITH.REST to 'REST' instead of 'Rest' #1927

merged 2 commits into from
Sep 12, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 12, 2024 •
edited
Loading

Description / Motivation

Set FETCH_WITH.REST to 'REST' instead of 'Rest' to match the value we mention in our docs

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 12, 2024 07:15
yavorsk
yavorsk approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@yavorsk yavorsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good👍

@illiakovalenko illiakovalenko merged commit b9ecb63 into dev Sep 12, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/JSS-3774 branch September 12, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yavorsk yavorsk yavorsk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @yavorsk