VB.NET HasExactlyNArguments method considers null argument list and 0 arguments the same. #7458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
changed the title
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
mary-georgiou-sonarsource
added
Area: VB.NET
pavel-mikula-sonarsource
requested changes
Jun 19, 2023
analyzers/src/SonarAnalyzer.VisualBasic/Extensions/InvocationExpressionSyntaxExtensions.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
github-actions
bot
assigned pavel-mikula-sonarsource and unassigned mary-georgiou-sonarsource
pavel-mikula-sonarsource
approved these changes
Jun 19, 2023
Comment on lines
34
to
35
| ? count == 0 | ||
| : invocation.ArgumentList.Arguments.Count == count; |
There was a problem hiding this comment.
Whitespace
Suggested change
| ? count == 0 | |
| : invocation.ArgumentList.Arguments.Count == count; | |
| ? count == 0 | |
| : invocation.ArgumentList.Arguments.Count == count; |
| @@ -30,7 +30,9 @@ internal static class InvocationExpressionSyntaxExtensions | |||
| invocation.ArgumentList.Arguments.GetSymbolsOfKnownType(knownType, semanticModel); | |||
|
|
|||
| internal static bool HasExactlyNArguments(this InvocationExpressionSyntax invocation, int count) => | |||
| invocation?.ArgumentList != null && invocation.ArgumentList.Arguments.Count == count; | |||
| invocation?.ArgumentList == null | |||
There was a problem hiding this comment.
Better null check
Suggested change
| invocation?.ArgumentList == null | |
| invocation?.ArgumentList is null |
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned pavel-mikula-sonarsource
mary-georgiou-sonarsource
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In VB.NET a method can be called by invocation, for example,
d.Dispose(), but it can be called also without the parentheses via member accessd.Dispose.So having an argument list with 0 arguments and having no argument list at all is the same thing in VB.NET context.