Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VB.NET HasExactlyNArguments method considers null argument list and 0 arguments the same. #7458

Merged
merged 4 commits into from
Jun 20, 2023
Merged

VB.NET HasExactlyNArguments method considers null argument list and 0 arguments the same. #7458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
31c7756
when arguments are null in invocation consider it n=0
mary-georgiou-sonarsource Jun 16, 2023
9327be4
rework condition
mary-georgiou-sonarsource Jun 19, 2023
9e9781c
remove unsued usings
mary-georgiou-sonarsource Jun 19, 2023
2c83612
apply comments
mary-georgiou-sonarsource Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion analyzers/src/SonarAnalyzer.VisualBasic/Extensions/InvocationExpressionSyntaxExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ internal static IEnumerable<ISymbol> GetArgumentSymbolsOfKnownType(this Invocati
invocation.ArgumentList.Arguments.GetSymbolsOfKnownType(knownType, semanticModel);

internal static bool HasExactlyNArguments(this InvocationExpressionSyntax invocation, int count) =>
invocation?.ArgumentList != null && invocation.ArgumentList.Arguments.Count == count;
invocation?.ArgumentList is null
? count == 0
: invocation.ArgumentList.Arguments.Count == count;

internal static bool TryGetOperands(this InvocationExpressionSyntax invocation, out SyntaxNode left, out SyntaxNode right)
{
Expand Down
2 changes: 1 addition & 1 deletion ...arAnalyzer.VisualBasic/SymbolicExecution/Roslyn/ObjectsShouldNotBeDisposedMoreThanOnce.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ public override void Visit(SyntaxNode node)
}

public override void VisitInvocationExpression(InvocationExpressionSyntax node) =>
Result = node.HasExactlyNArguments(0) || node.ArgumentList is null;
Result = node.HasExactlyNArguments(0);
}
}