SE: Learn from bool collection methods #9497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mary-georgiou-sonarsource
added
Area: CFG/SE
mary-georgiou-sonarsource
force-pushed
the
mary/fp-s2259
branch
from
718a236
to
b37cf25
Compare
mary-georgiou-sonarsource
force-pushed
the
mary/fp-s2259
branch
from
a79e9b0
to
9cb7d94
Compare
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned mary-georgiou-sonarsource
| @@ -236,7 +234,6 @@ public static int NonLinqExtensionNullChecking(this IEnumerable<int> source) | |||
|
|
|||
| [DataTestMethod] | |||
| [DataRow("Count")] | |||
| // [DataRow("Any")] | |||
There was a problem hiding this comment.
These cases at this point need their own test - not sure if it worths it.
| @@ -49,11 +49,9 @@ public void InstanceReference_SetsNotNull_VB() | |||
|
|
|||
| [DataTestMethod] | |||
| [DataRow("Aggregate", "(x, y) => x")] | |||
| //[DataRow("Any")] | |||
There was a problem hiding this comment.
These cases at this point need their own test - not sure if it worths it.
zsolt-kolbay-sonarsource
suggested changes
Jul 3, 2024
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IInvocationOperationExtensions.cs
Outdated
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IInvocationOperationExtensions.cs
Outdated
Show resolved
Hide resolved
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.cs
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.Enumerable.cs
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.Enumerable.cs
Outdated
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.Enumerable.cs
Outdated
Show resolved
Hide resolved
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned zsolt-kolbay-sonarsource
github-actions
bot
assigned zsolt-kolbay-sonarsource and unassigned mary-georgiou-sonarsource
mary-georgiou-sonarsource
force-pushed
the
mary/fp-s2259
branch
from
006d2fa
to
776f880
Compare
analyzers/src/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.cs
Outdated
Show resolved
Hide resolved
Comment on lines
+92
to
+96
| return states.SelectMany(x => new List<ProgramState> | ||
| { | ||
| x.SetOperationConstraint(invocation, ObjectConstraint.Null), | ||
| x.SetOperationConstraint(invocation, ObjectConstraint.NotNull) | ||
| }).ToArray(); |
There was a problem hiding this comment.
don't review this - it will change in the next PR.
github-actions
bot
assigned mary-georgiou-sonarsource and unassigned zsolt-kolbay-sonarsource
Tim-Pohlmann
requested changes
Jul 4, 2024
.../tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IInvocationOperationExtensions.cs
Outdated
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/Extensions/IInvocationOperationExtensions.cs
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.Enumerable.cs
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.Enumerable.cs
Outdated
Show resolved
Hide resolved
...c/SonarAnalyzer.Common/SymbolicExecution/Roslyn/OperationProcessors/Invocation.Enumerable.cs
Outdated
Show resolved
Hide resolved
mary-georgiou-sonarsource
force-pushed
the
mary/fp-s2259
branch
from
6d75ee2
to
24e22d7
Compare
Tim-Pohlmann
requested changes
Jul 4, 2024
.../tests/SonarAnalyzer.Test/SymbolicExecution/Roslyn/RoslynSymbolicExecutionTest.Invocation.cs
Outdated
Show resolved
Hide resolved
|
|
Tim-Pohlmann
approved these changes
Jul 4, 2024
| @@ -42,4 +42,10 @@ internal static class IInvocationOperationExtensions | |||
| || (invocation.TargetMethod.IsExtensionMethod | |||
| && !invocation.Arguments.IsEmpty | |||
| && state.ResolveCaptureAndUnwrapConversion(invocation.Arguments[0].ToArgument().Value).Kind == OperationKindEx.InstanceReference); | |||
|
|
|||
| public static IOperation GetInstance(this IInvocationOperationWrapper invocation, ProgramState state) => | |||
There was a problem hiding this comment.
You could improve coverage by adding UTs for this extension method. This would be good practice in general. I'm sorry I missed mentioning this earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8266 and #7457