Add keychron k6 rgb - ansi version to the updated structure #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dexter93
reviewed
Nov 29, 2023
|
|
||
| #pragma once | ||
|
|
||
| #define DYNAMIC_KEYMAP_LAYER_COUNT 4 |
There was a problem hiding this comment.
Suggested change
| #define DYNAMIC_KEYMAP_LAYER_COUNT 4 |
4 is the default value. Only declare it here if you're modifying it
Comment on lines
+114
to
+185
| { "matrix": [ 0, 0 ], "flags": 4, "x": 0, "y": 0 }, | ||
| { "matrix": [ 0, 1 ], "flags": 4, "x": 12, "y": 0 }, | ||
| { "matrix": [ 0, 2 ], "flags": 4, "x": 25, "y": 0 }, | ||
| { "matrix": [ 0, 3 ], "flags": 4, "x": 37, "y": 0 }, | ||
| { "matrix": [ 0, 4 ], "flags": 4, "x": 50, "y": 0 }, | ||
| { "matrix": [ 0, 5 ], "flags": 4, "x": 62, "y": 0 }, | ||
| { "matrix": [ 0, 6 ], "flags": 4, "x": 75, "y": 0 }, | ||
| { "matrix": [ 0, 7 ], "flags": 4, "x": 87, "y": 0 }, | ||
| { "matrix": [ 0, 8 ], "flags": 4, "x": 100, "y": 0 }, | ||
| { "matrix": [ 0, 9 ], "flags": 4, "x": 112, "y": 0 }, | ||
| { "matrix": [ 0, 10 ], "flags": 4, "x": 124, "y": 0 }, | ||
| { "matrix": [ 0, 11 ], "flags": 4, "x": 137, "y": 0 }, | ||
| { "matrix": [ 0, 12 ], "flags": 4, "x": 149, "y": 0 }, | ||
| { "matrix": [ 0, 13 ], "flags": 4, "x": 168, "y": 0 }, | ||
| { "matrix": [ 0, 15 ], "flags": 4, "x": 187, "y": 0 }, | ||
|
|
||
| { "matrix": [ 1, 0 ], "flags": 4, "x": 3, "y": 16 }, | ||
| { "matrix": [ 1, 1 ], "flags": 4, "x": 19, "y": 16 }, | ||
| { "matrix": [ 1, 2 ], "flags": 4, "x": 31, "y": 16 }, | ||
| { "matrix": [ 1, 3 ], "flags": 4, "x": 44, "y": 16 }, | ||
| { "matrix": [ 1, 4 ], "flags": 4, "x": 56, "y": 16 }, | ||
| { "matrix": [ 1, 5 ], "flags": 4, "x": 68, "y": 16 }, | ||
| { "matrix": [ 1, 6 ], "flags": 4, "x": 81, "y": 16 }, | ||
| { "matrix": [ 1, 7 ], "flags": 4, "x": 93, "y": 16 }, | ||
| { "matrix": [ 1, 8 ], "flags": 4, "x": 106, "y": 16 }, | ||
| { "matrix": [ 1, 9 ], "flags": 4, "x": 118, "y": 16 }, | ||
| { "matrix": [ 1, 10 ], "flags": 4, "x": 131, "y": 16 }, | ||
| { "matrix": [ 1, 11 ], "flags": 4, "x": 143, "y": 16 }, | ||
| { "matrix": [ 1, 12 ], "flags": 4, "x": 156, "y": 16 }, | ||
| { "matrix": [ 1, 13 ], "flags": 4, "x": 168, "y": 16 }, | ||
| { "matrix": [ 1, 15 ], "flags": 4, "x": 187, "y": 16 }, | ||
|
|
||
| { "matrix": [ 2, 0 ], "flags": 4, "x": 5, "y": 32 }, | ||
| { "matrix": [ 2, 1 ], "flags": 4, "x": 22, "y": 32 }, | ||
| { "matrix": [ 2, 2 ], "flags": 4, "x": 34, "y": 32 }, | ||
| { "matrix": [ 2, 3 ], "flags": 4, "x": 47, "y": 32 }, | ||
| { "matrix": [ 2, 4 ], "flags": 4, "x": 59, "y": 32 }, | ||
| { "matrix": [ 2, 5 ], "flags": 4, "x": 72, "y": 32 }, | ||
| { "matrix": [ 2, 6 ], "flags": 4, "x": 84, "y": 32 }, | ||
| { "matrix": [ 2, 7 ], "flags": 4, "x": 96, "y": 32 }, | ||
| { "matrix": [ 2, 8 ], "flags": 4, "x": 109, "y": 32 }, | ||
| { "matrix": [ 2, 9 ], "flags": 4, "x": 121, "y": 32 }, | ||
| { "matrix": [ 2, 10 ], "flags": 4, "x": 134, "y": 32 }, | ||
| { "matrix": [ 2, 11 ], "flags": 4, "x": 146, "y": 32 }, | ||
| { "matrix": [ 2, 13 ], "flags": 4, "x": 166, "y": 32 }, | ||
| { "matrix": [ 2, 15 ], "flags": 4, "x": 187, "y": 32 }, | ||
|
|
||
| { "matrix": [ 3, 0 ], "flags": 4, "x": 8, "y": 48 }, | ||
| { "matrix": [ 3, 2 ], "flags": 4, "x": 28, "y": 48 }, | ||
| { "matrix": [ 3, 3 ], "flags": 4, "x": 40, "y": 48 }, | ||
| { "matrix": [ 3, 4 ], "flags": 4, "x": 53, "y": 48 }, | ||
| { "matrix": [ 3, 5 ], "flags": 4, "x": 65, "y": 48 }, | ||
| { "matrix": [ 3, 6 ], "flags": 4, "x": 78, "y": 48 }, | ||
| { "matrix": [ 3, 7 ], "flags": 4, "x": 90, "y": 48 }, | ||
| { "matrix": [ 3, 8 ], "flags": 4, "x": 103, "y": 48 }, | ||
| { "matrix": [ 3, 9 ], "flags": 4, "x": 115, "y": 48 }, | ||
| { "matrix": [ 3, 10 ], "flags": 4, "x": 128, "y": 48 }, | ||
| { "matrix": [ 3, 11 ], "flags": 4, "x": 140, "y": 48 }, | ||
| { "matrix": [ 3, 13 ], "flags": 4, "x": 157, "y": 48 }, | ||
| { "matrix": [ 3, 14 ], "flags": 4, "x": 174, "y": 48 }, | ||
| { "matrix": [ 3, 15 ], "flags": 4, "x": 187, "y": 48 }, | ||
|
|
||
| { "matrix": [ 4, 0 ], "flags": 4, "x": 2, "y": 64 }, | ||
| { "matrix": [ 4, 1 ], "flags": 4, "x": 17, "y": 64 }, | ||
| { "matrix": [ 4, 2 ], "flags": 4, "x": 33, "y": 64 }, | ||
| { "matrix": [ 4, 6 ], "flags": 4, "x": 79, "y": 64 }, | ||
| { "matrix": [ 4, 10 ], "flags": 4, "x": 124, "y": 64 }, | ||
| { "matrix": [ 4, 11 ], "flags": 4, "x": 137, "y": 64 }, | ||
| { "matrix": [ 4, 12 ], "flags": 4, "x": 149, "y": 64 }, | ||
| { "matrix": [ 4, 13 ], "flags": 4, "x": 162, "y": 64 }, | ||
| { "matrix": [ 4, 14 ], "flags": 4, "x": 174, "y": 64 }, | ||
| { "matrix": [ 4, 15 ], "flags": 4, "x": 187, "y": 64 } |
There was a problem hiding this comment.
There was a problem hiding this comment.
That is what I was initially trying to use but I'm not exactly sure why the values cap out at 187 instead of 224
since
x = 224 / (NUMBER_OF_COLS - 1) * COL_POSITION
so last column should be
x = 224 / (16 - 1) * 15 = 224
But since k2v2 and k6 have same number of columns I'm not sure why It was 187
There was a problem hiding this comment.
there's a nifty tool to automate this kind of headache here https://xelus.netlify.app/guides/kle_to_rgb_parser
dexter93
force-pushed
the
sn32_develop
branch
from
b4661f4
to
a5ecb97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Copied from keychron k2v2 and modified the layout and rgb matrix in the info.json
I'm unsure about the
xvalues in the rgb matrix in info.jsonTypes of Changes
Issues Fixed or Closed by This PR
Checklist