Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary _BaseSound._unload_instance function. #496

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CookStar
Copy link
Contributor

This fixes the following error when unloading the plugin

Output:

[Source.Python]
[SP] Caught an Exception:
Traceback (most recent call last):
  File "..\addons\source-python\packages\source-python\plugins\manager.py", line 437, in _unload_auto_unload_instances
    instance._unload_instance()
  File "..\addons\source-python\packages\source-python\engines\sound.py", line 292, in _unload_instance
    self._downloads._unload_instance()
  File "..\addons\source-python\packages\source-python\stringtables\downloads.py", line 98, in _unload_instance
    _downloadables_list.remove(self)

ValueError: list.remove(x): x not in list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant