Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Improve pk index compaction score calculation strategy #42803

Merged
merged 1 commit into from
Mar 20, 2024
Merged

[Enhancement] Improve pk index compaction score calculation strategy #42803

merged 1 commit into from
Mar 20, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented Mar 19, 2024 •
edited
Loading

Why I'm doing:

When calculate pk index compaction score, we need to read index meta from RocksDB, and this is not efficient.

What I'm doing:

Store pk index compaction score in each tablet class, and re-calculate it when pk apply finish.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner March 19, 2024 12:20
@luohaha luohaha force-pushed the improve-pindex-score-calc branch 6 times, most recently from 2562562 to 1081317 Compare March 20, 2024 06:42
@luohaha luohaha changed the title [Enhancement] Improved pk index compaction score calculation strategy [Enhancement] Improve pk index compaction score calculation strategy Mar 20, 2024
wyb
wyb previously approved these changes Mar 20, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@luohaha luohaha enabled auto-merge (squash) March 20, 2024 12:49
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 11 / 11 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/persistent_index.cpp 3 3 100.00% []
🔵 be/src/storage/tablet_updates.h 1 1 100.00% []
🔵 be/src/storage/tablet_updates.cpp 7 7 100.00% []

@luohaha luohaha merged commit 25afd79 into StarRocks:main Mar 20, 2024
41 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Mar 20, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Mar 20, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions github-actions bot removed the 3.0 label Mar 20, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Mar 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 20, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 20, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 20, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 20, 2024
@luohaha @mergify
[Enhancement] Improve pk index compaction score calculation strategy (#…
d98527a 
…42803)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 25afd79)

# Conflicts:
#	be/src/storage/primary_index.cpp
#	be/src/storage/primary_index.h
#	be/src/storage/tablet_updates.cpp
#	be/src/storage/tablet_updates.h
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 20, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Mar 20, 2024
@luohaha @mergify
[Enhancement] Improve pk index compaction score calculation strategy (#…
50f74cb 
…42803)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 25afd79)
This was referenced Mar 20, 2024
Closed
Merged
mergify bot pushed a commit that referenced this pull request Mar 20, 2024
@luohaha @mergify
[Enhancement] Improve pk index compaction score calculation strategy (#…
13ca615 
…42803)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 25afd79)
@mergify mergify bot mentioned this pull request Mar 20, 2024
Merged
41 tasks
mergify bot pushed a commit that referenced this pull request Mar 20, 2024
@luohaha @mergify
[Enhancement] Improve pk index compaction score calculation strategy (#…
a05efc0 
…42803)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 25afd79)

# Conflicts:
#	be/src/storage/primary_index.cpp
#	be/src/storage/primary_index.h
#	be/src/storage/tablet_updates.cpp
#	be/src/storage/tablet_updates.h
@mergify mergify bot mentioned this pull request Mar 20, 2024
Closed
41 tasks
wanpengfei-git pushed a commit that referenced this pull request Mar 20, 2024
@mergify @luohaha
[Enhancement] Improve pk index compaction score calculation strategy …
e6ff70a 
…(backport #42803) (#42875)

Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Mar 20, 2024
@mergify @luohaha
[Enhancement] Improve pk index compaction score calculation strategy …
3f1bb4b 
…(backport #42803) (#42876)

Co-authored-by: Yixin Luo <[email protected]>
luohaha added a commit to luohaha/starrocks that referenced this pull request Apr 22, 2024
@luohaha
[Enhancement] Improve pk index compaction score calculation strategy (S…
2aabd0f 
…tarRocks#42803)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 25afd79)

resolve conflict

Signed-off-by: Yixin Luo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sevev sevev sevev approved these changes

@wyb wyb wyb approved these changes

Assignees

@luohaha luohaha

Labels
2.5 3.1-merged 3.1 3.2-merged 3.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luohaha @wyb @sevev