Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Improve pk index compaction score calculation strategy (backport #42803) #42877

Closed
wants to merge 2 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 20, 2024

Why I'm doing:

When calculate pk index compaction score, we need to read index meta from RocksDB, and this is not efficient.

What I'm doing:

Store pk index compaction score in each tablet class, and re-calculate it when pk apply finish.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #42803 done by [Mergify](https://mergify.com). ## Why I'm doing: When calculate pk index compaction score, we need to read index meta from RocksDB, and this is not efficient.

What I'm doing:

Store pk index compaction score in each tablet class, and re-calculate it when pk apply finish.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…42803)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 25afd79)

# Conflicts:
#	be/src/storage/primary_index.cpp
#	be/src/storage/primary_index.h
#	be/src/storage/tablet_updates.cpp
#	be/src/storage/tablet_updates.h
@mergify mergify bot added the conflicts label Mar 20, 2024
Copy link
Contributor Author

mergify bot commented Mar 20, 2024

Cherry-pick of 25afd79 has failed:

On branch mergify/bp/branch-3.0/pr-42803
Your branch is up to date with 'origin/branch-3.0'.

You are currently cherry-picking commit 25afd79a4d.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   be/src/storage/persistent_index.cpp
	modified:   be/src/storage/persistent_index.h
	modified:   be/test/storage/tablet_updates_test.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/storage/primary_index.cpp
	both modified:   be/src/storage/primary_index.h
	both modified:   be/src/storage/tablet_updates.cpp
	both modified:   be/src/storage/tablet_updates.h

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot closed this Mar 20, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) March 20, 2024 14:53
auto-merge was automatically disabled March 20, 2024 14:53

Pull request was closed

Copy link
Contributor Author

mergify bot commented Mar 20, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot deleted the mergify/bp/branch-3.0/pr-42803 branch March 20, 2024 14:54
@luohaha luohaha restored the mergify/bp/branch-3.0/pr-42803 branch April 22, 2024 12:40
@luohaha luohaha reopened this Apr 22, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) April 22, 2024 12:41
Signed-off-by: Yixin Luo <[email protected]>
@luohaha luohaha closed this Apr 22, 2024
auto-merge was automatically disabled April 22, 2024 13:19

Pull request was closed

@mergify mergify bot deleted the mergify/bp/branch-3.0/pr-42803 branch April 22, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant