Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] release metadata memory after rowsets have been compacted in pk table #46067

Merged
merged 1 commit into from
May 27, 2024
Merged

[Enhancement] release metadata memory after rowsets have been compacted in pk table #46067

merged 1 commit into from
May 27, 2024

Conversation

luohaha
Copy link
Contributor

@luohaha luohaha commented May 22, 2024 •
edited
Loading

Why I'm doing:

After Rowset generated, SR will load metadata about Rowset, Segment and ColumnReader, which will cause lots of memory, and it's good for query performance.
And in DUP/AGG/UNIQ table, SR will release these memory after Rowset has been compacted, but in PK table, it won't.

So now, PK table will only release metadata memory after Rowset has been deleted, even after this Rowset is too old to be queried anymore. It will waste memory here.

What I'm doing:

release metadata memory after rowsets have been compacted in PK table.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@luohaha luohaha requested a review from a team as a code owner May 22, 2024 09:14
@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/tablet_updates.cpp 4 4 100.00% []

@wyb wyb merged commit 0471705 into StarRocks:main May 27, 2024
64 of 66 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 27, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.2 label May 27, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.0

@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label May 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 27, 2024 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 27, 2024
@luohaha @mergify
[Enhancement] release metadata memory after rowsets have been compact…
3bfeef1 
…ed in pk table (#46067)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0471705)
@mergify mergify bot mentioned this pull request May 27, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request May 27, 2024
@luohaha @mergify
[Enhancement] release metadata memory after rowsets have been compact…
0d6513e 
…ed in pk table (#46067)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0471705)

# Conflicts:
#	be/src/storage/tablet_updates.cpp
mergify bot pushed a commit that referenced this pull request May 27, 2024
@luohaha @mergify
[Enhancement] release metadata memory after rowsets have been compact…
28b5170 
…ed in pk table (#46067)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0471705)

# Conflicts:
#	be/src/storage/tablet_updates.cpp
This was referenced May 27, 2024
Merged
Merged
mergify bot pushed a commit that referenced this pull request May 27, 2024
@luohaha @mergify
[Enhancement] release metadata memory after rowsets have been compact…
844d5a1 
…ed in pk table (#46067)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0471705)

# Conflicts:
#	be/src/storage/tablet_updates.cpp
@mergify mergify bot mentioned this pull request May 27, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request May 27, 2024
@luohaha @mergify
[Enhancement] release metadata memory after rowsets have been compact…
98f0eab 
…ed in pk table (#46067)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0471705)

# Conflicts:
#	be/src/storage/tablet_updates.cpp
@mergify mergify bot mentioned this pull request May 27, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request May 27, 2024
@mergify @luohaha
[Enhancement] release metadata memory after rowsets have been compact…
77f2d95 
…ed in pk table (backport #46067) (#46303)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 27, 2024
@mergify @luohaha
[Enhancement] release metadata memory after rowsets have been compact…
0598278 
…ed in pk table (backport #46067) (#46304)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 27, 2024
@mergify @luohaha
[Enhancement] release metadata memory after rowsets have been compact…
d6ca165 
…ed in pk table (backport #46067) (#46305)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request May 27, 2024
@mergify @luohaha
[Enhancement] release metadata memory after rowsets have been compact…
18268d5 
…ed in pk table (backport #46067) (#46306)

Signed-off-by: Yixin Luo <[email protected]>
Co-authored-by: Yixin Luo <[email protected]>
luohaha added a commit that referenced this pull request Jun 1, 2024
@mergify @luohaha
[Enhancement] release metadata memory after rowsets have been compact…
55d6f56 
…ed in pk table (backport #46067) (#46302)

Co-authored-by: Yixin Luo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueeyu trueeyu trueeyu approved these changes

@wyb wyb wyb approved these changes

@decster decster decster approved these changes

Assignees

@luohaha luohaha

Labels
2.5-merged 3.0-merged 3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luohaha @decster @wyb @trueeyu