Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] release metadata memory after rowsets have been compacted in pk table (backport #46067) #46306

Merged
merged 2 commits into from
May 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 27, 2024

Why I'm doing:

After Rowset generated, SR will load metadata about Rowset, Segment and ColumnReader, which will cause lots of memory, and it's good for query performance.
And in DUP/AGG/UNIQ table, SR will release these memory after Rowset has been compacted, but in PK table, it won't.

So now, PK table will only release metadata memory after Rowset has been deleted, even after this Rowset is too old to be queried anymore. It will waste memory here.

What I'm doing:

release metadata memory after rowsets have been compacted in PK table.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #46067 done by [Mergify](https://mergify.com). ## Why I'm doing: After `Rowset` generated, SR will load metadata about `Rowset`, `Segment` and `ColumnReader`, which will cause lots of memory, and it's good for query performance. And in DUP/AGG/UNIQ table, SR will release these memory after `Rowset` has been compacted, but in PK table, it won't.

So now, PK table will only release metadata memory after Rowset has been deleted, even after this Rowset is too old to be queried anymore. It will waste memory here.

What I'm doing:

release metadata memory after rowsets have been compacted in PK table.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

…ed in pk table (#46067)

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 0471705)

# Conflicts:
#	be/src/storage/tablet_updates.cpp
@mergify mergify bot added the conflicts label May 27, 2024
Copy link
Contributor Author

mergify bot commented May 27, 2024

Cherry-pick of 0471705 has failed:

On branch mergify/bp/branch-2.5/pr-46067
Your branch is up to date with 'origin/branch-2.5'.

You are currently cherry-picking commit 0471705863.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/storage/tablet_updates.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented May 27, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this May 27, 2024
@mergify mergify bot deleted the mergify/bp/branch-2.5/pr-46067 branch May 27, 2024 07:30
@luohaha luohaha restored the mergify/bp/branch-2.5/pr-46067 branch May 27, 2024 07:48
@luohaha luohaha reopened this May 27, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) May 27, 2024 07:48
Signed-off-by: Yixin Luo <[email protected]>
@wanpengfei-git wanpengfei-git merged commit 18268d5 into branch-2.5 May 27, 2024
30 of 31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-2.5/pr-46067 branch May 27, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants