Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix transaction of insert load job can not be aborted when job has been cancelled #48059

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[BugFix] Fix transaction of insert load job can not be aborted when job has been cancelled #48059

merged 2 commits into from
Jul 31, 2024

Conversation

caneGuy
Copy link
Contributor

@caneGuy caneGuy commented Jul 9, 2024 •
edited
Loading

Why I'm doing:

What I'm doing:

Txn of Insert job can not be aborted when job has been cancelled since transaction id was not set

2024-07-09 16:55:58.698+08:00 WARN (thrift-server-pool-50149|430837) [LoadJob.unprotectedExecuteCancel():672] LOAD_JOB=415348, transaction_id={0}, error_msg={Failed to execute load with error: user cancel}
2024-07-09 16:55:58.698+08:00 WARN (thrift-server-pool-50149|430837) [LoadJob.unprotectedExecuteCancel():710] LOAD_JOB=415348, transaction_id={0}, error_msg={failed to abort txn when job is cancelled. transaction not found: 0}

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@caneGuy caneGuy changed the title [EMR][BugFix] Fix transaction of insert load job can not be aborted when job has been cancelled [BugFix] Fix transaction of insert load job can not be aborted when job has been cancelled Jul 9, 2024
@mergify mergify bot assigned caneGuy Jul 9, 2024
@caneGuy
Copy link
Contributor Author

caneGuy commented Jul 10, 2024

run FE UT

@caneGuy
resolve comments
acb6cc9 
Signed-off-by: caneGuy <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 30, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 3 / 3 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/loadv2/LoadMgr.java 1 1 100.00% []
🔵 com/starrocks/load/loadv2/InsertLoadJob.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions github-actions bot added the 3.1 label Jul 30, 2024
@miomiocat miomiocat enabled auto-merge (squash) July 30, 2024 14:25
@miomiocat miomiocat merged commit d952829 into StarRocks:main Jul 31, 2024
56 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jul 31, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Jul 31, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Jul 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 31, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 31, 2024
@caneGuy @mergify
[BugFix] Fix transaction of insert load job can not be aborted when j…
ae676cc 
…ob has been cancelled (#48059)

(cherry picked from commit d952829)
@mergify mergify bot mentioned this pull request Jul 31, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 31, 2024
@caneGuy @mergify
[BugFix] Fix transaction of insert load job can not be aborted when j…
e7d6432 
…ob has been cancelled (#48059)

(cherry picked from commit d952829)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/loadv2/InsertLoadJob.java
#	fe/fe-core/src/main/java/com/starrocks/load/loadv2/LoadMgr.java
@mergify mergify bot mentioned this pull request Jul 31, 2024
Merged
24 tasks
mergify bot pushed a commit that referenced this pull request Jul 31, 2024
@caneGuy @mergify
[BugFix] Fix transaction of insert load job can not be aborted when j…
3208e66 
…ob has been cancelled (#48059)

(cherry picked from commit d952829)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/loadv2/InsertLoadJob.java
#	fe/fe-core/src/main/java/com/starrocks/load/loadv2/LoadMgr.java
@mergify mergify bot mentioned this pull request Jul 31, 2024
Merged
42 tasks
@caneGuy caneGuy deleted the zhoukang/insert-error branch July 31, 2024 02:53
@xiangguangyxg
Copy link
Contributor

ignore backport check: 3.3.2

wanpengfei-git pushed a commit that referenced this pull request Aug 5, 2024
@mergify @caneGuy @xiangguangyxg
[BugFix] Fix transaction of insert load job can not be aborted when j…
8ff63fb 
…ob has been cancelled (backport #48059) (#49205)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: zhoukang <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 5, 2024
@mergify @caneGuy @xiangguangyxg
[BugFix] Fix transaction of insert load job can not be aborted when j…
79ef297 
…ob has been cancelled (backport #48059) (#49204)

Signed-off-by: xiangguangyxg <[email protected]>
Co-authored-by: zhoukang <[email protected]>
Co-authored-by: xiangguangyxg <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
@mergify @caneGuy
[BugFix] Fix transaction of insert load job can not be aborted when j…
67599d3 
…ob has been cancelled (backport #48059) (#49203)

Co-authored-by: zhoukang <[email protected]>
smartlxh pushed a commit to smartlxh/starrocks that referenced this pull request Oct 16, 2024
@caneGuy
[Backport][BugFix] Fix transaction of insert load job can not be abor…
26c4a32 
…ted when job has been cancelled (backport StarRocks#48059) (StarRocks#49204)

Signed-off-by: caneGuy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangguangyxg xiangguangyxg xiangguangyxg approved these changes

@miomiocat miomiocat miomiocat approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@caneGuy caneGuy

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caneGuy @xiangguangyxg @kevincai @miomiocat