Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix transaction of insert load job can not be aborted when job has been cancelled (backport #48059) #49203

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 31, 2024

Why I'm doing:

What I'm doing:

Txn of Insert job can not be aborted when job has been cancelled since transaction id was not set

2024-07-09 16:55:58.698+08:00 WARN (thrift-server-pool-50149|430837) [LoadJob.unprotectedExecuteCancel():672] LOAD_JOB=415348, transaction_id={0}, error_msg={Failed to execute load with error: user cancel}
2024-07-09 16:55:58.698+08:00 WARN (thrift-server-pool-50149|430837) [LoadJob.unprotectedExecuteCancel():710] LOAD_JOB=415348, transaction_id={0}, error_msg={failed to abort txn when job is cancelled. transaction not found: 0}

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #48059 done by [Mergify](https://mergify.com).

Why I'm doing:

What I'm doing:

Txn of Insert job can not be aborted when job has been cancelled since transaction id was not set

2024-07-09 16:55:58.698+08:00 WARN (thrift-server-pool-50149|430837) [LoadJob.unprotectedExecuteCancel():672] LOAD_JOB=415348, transaction_id={0}, error_msg={Failed to execute load with error: user cancel}
2024-07-09 16:55:58.698+08:00 WARN (thrift-server-pool-50149|430837) [LoadJob.unprotectedExecuteCancel():710] LOAD_JOB=415348, transaction_id={0}, error_msg={failed to abort txn when job is cancelled. transaction not found: 0}

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Jul 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@wanpengfei-git wanpengfei-git merged commit 67599d3 into branch-3.3 Aug 8, 2024
37 of 38 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-48059 branch August 8, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants