[Enhancement] avoid BE OOM when handle large number of tablet writes #48495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![starrocks-cr[bot]](https://avatars.githubusercontent.com/in/404334?s=60&v=4){kind=small}
luohaha
force-pushed
the
improve-load-mem
branch
from
9a83b1d
to
8477781
Compare
luohaha
force-pushed
the
improve-load-mem
branch
2 times, most recently
from
8c91da0
to
4cf7dac
Compare
kevincai
reviewed
Jul 18, 2024
kevincai
previously approved these changes
Jul 19, 2024
kevincai
previously approved these changes
Jul 19, 2024
Signed-off-by: luohaha <[email protected]>
luohaha
force-pushed
the
improve-load-mem
branch
from
943f99f
to
6b82d76
Compare
wyb
reviewed
Jul 19, 2024
Signed-off-by: luohaha <[email protected]>
luohaha
force-pushed
the
improve-load-mem
branch
from
6b82d76
to
05bce62
Compare
Signed-off-by: luohaha <[email protected]>
wyb
previously approved these changes
Jul 19, 2024
Signed-off-by: luohaha <[email protected]>
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]✅ pass : 11 / 13 (84.62%) file detail
|
kevincai
approved these changes
Jul 19, 2024
wyb
approved these changes
Jul 20, 2024
|
@Mergifyio backport branch-3.3 |
|
@Mergifyio backport branch-3.2 |
✅ Backports have been created
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
…48495) Signed-off-by: luohaha <[email protected]> (cherry picked from commit 6e17dd6)
Merged
42 tasks
mergify bot
pushed a commit
that referenced
this pull request
Jul 20, 2024
…48495) Signed-off-by: luohaha <[email protected]> (cherry picked from commit 6e17dd6)
Merged
42 tasks
luohaha
added a commit
that referenced
this pull request
Jul 20, 2024
…(backport #48495) (#48645) Co-authored-by: Yixin Luo <[email protected]>
wanpengfei-git
pushed a commit
that referenced
this pull request
Jul 20, 2024
…(backport #48495) (#48646) Signed-off-by: Yixin Luo <[email protected]> Co-authored-by: Yixin Luo <[email protected]>
dujijun007
pushed a commit
to dujijun007/starrocks
that referenced
this pull request
Jul 29, 2024
…tarRocks#48495) Signed-off-by: luohaha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
When BE handle large number of tablet writes, each delta writer will create a empty memtable, but even this memtable is empty, lots of them can still result in significant memory consumption, which will cause BE OOM.
What I'm doing:
Add a hard limit (be.conf
load_process_max_memory_hard_limit_ratio) to loading memory consumption, that is when loading memory consumption is larger than hard limit, we don't allow new coming load task to open channel or create new memtable.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: