Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] avoid BE OOM when handle large number of tablet writes (backport #48495) #48645

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 20, 2024

Why I'm doing:

When BE handle large number of tablet writes, each delta writer will create a empty memtable, but even this memtable is empty, lots of them can still result in significant memory consumption, which will cause BE OOM.

What I'm doing:

Add a hard limit (be.conf load_process_max_memory_hard_limit_ratio) to loading memory consumption, that is when loading memory consumption is larger than hard limit, we don't allow new coming load task to open channel or create new memtable.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #48495 done by [Mergify](https://mergify.com). ## Why I'm doing: When BE handle large number of tablet writes, each delta writer will create a empty memtable, but even this memtable is empty, lots of them can still result in significant memory consumption, which will cause BE OOM.

What I'm doing:

Add a hard limit (be.conf load_process_max_memory_hard_limit_ratio) to loading memory consumption, that is when loading memory consumption is larger than hard limit, we don't allow new coming load task to open channel or create new memtable.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@luohaha luohaha merged commit 1e5e85b into branch-3.3 Jul 20, 2024
32 of 33 checks passed
@luohaha luohaha deleted the mergify/bp/branch-3.3/pr-48495 branch July 20, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant