Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add build arch info when showing FE/BE version #48572

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[Feature] Add build arch info when showing FE/BE version #48572

merged 1 commit into from
Jul 18, 2024

Conversation

nshangyiming
Copy link
Contributor

@nshangyiming nshangyiming commented Jul 18, 2024 •
edited
Loading

Why I'm doing:

User can rely on this info to determin whether it's the right package to run on current host.

What I'm doing:

Add build arch info when showing FE/BE version.

# sh bin/show_fe_version.sh
...
Build arch: arm64
...

Tested on macOS, AWS graviton, and x86 ECS,
the corresponding values are: arm64, aarch64, x86_64.

Fixes #48575.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@nshangyiming nshangyiming requested a review from a team as a code owner July 18, 2024 09:32
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 18, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

❌ fail : 0 / 1 (00.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/StarRocksFE.java 0 1 00.00% [323]

@alvin-celerdata alvin-celerdata merged commit 8fc6720 into StarRocks:main Jul 18, 2024
66 of 70 checks passed
@wanpengfei-git wanpengfei-git mentioned this pull request Jul 18, 2024
Closed
3 tasks
@nshangyiming
Copy link
Contributor Author

@mergify backport branch-3.3

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 19, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 19, 2024
@nshangyiming @mergify
[Feature] Add build arch info when showing FE/BE version (#48572)
e09b10a 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 8fc6720)
@mergify mergify bot mentioned this pull request Jul 19, 2024
Merged
42 tasks
@nshangyiming
Copy link
Contributor Author

@mergify backport branch-3.2

@nshangyiming
Copy link
Contributor Author

@mergify backport branch-3.1

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 19, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 19, 2024 •
edited
Loading

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 19, 2024
@nshangyiming @mergify
[Feature] Add build arch info when showing FE/BE version (#48572)
c9c24bf 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 8fc6720)
@mergify mergify bot mentioned this pull request Jul 19, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request Jul 19, 2024
@nshangyiming @mergify
[Feature] Add build arch info when showing FE/BE version (#48572)
9ea2069 
Signed-off-by: Dejun Xia <[email protected]>
(cherry picked from commit 8fc6720)
@mergify mergify bot mentioned this pull request Jul 19, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request Jul 19, 2024
@mergify @nshangyiming
[Feature] Add build arch info when showing FE/BE version (backport #4…
020c699 
…8572) (#48615)

Signed-off-by: Dejun Xia <[email protected]>
Co-authored-by: yiming <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 19, 2024
@mergify @nshangyiming
[Feature] Add build arch info when showing FE/BE version (backport #4…
c43062b 
…8572) (#48614)

Signed-off-by: Dejun Xia <[email protected]>
Co-authored-by: yiming <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jul 19, 2024
@mergify @nshangyiming
[Feature] Add build arch info when showing FE/BE version (backport #4…
5a5e218 
…8572) (#48613)

Signed-off-by: Dejun Xia <[email protected]>
Co-authored-by: yiming <[email protected]>
dujijun007 pushed a commit to dujijun007/starrocks that referenced this pull request Jul 29, 2024
@nshangyiming @dujijun007
[Feature] Add build arch info when showing FE/BE version (StarRocks#4…
6286dac 
…8572)

Signed-off-by: Dejun Xia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starrocks-cr starrocks-cr[bot] starrocks-cr[bot] left review comments

@dirtysalt dirtysalt dirtysalt approved these changes

@kevincai kevincai kevincai approved these changes

Assignees

@nshangyiming nshangyiming

Labels
3.1-merged 3.2-merged 3.3-merged version:3.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to add build arch info when showing FE/BE version
4 participants
@nshangyiming @kevincai @dirtysalt @alvin-celerdata