Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add build arch info when showing FE/BE version (backport #48572) #48615

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 19, 2024

Why I'm doing:

User can rely on this info to determin whether it's the right package to run on current host.

What I'm doing:

Add build arch info when showing FE/BE version.

# sh bin/show_fe_version.sh
...
Build arch: arm64
...

Tested on macOS, AWS graviton, and x86 ECS,
the corresponding values are: arm64, aarch64, x86_64.

Fixes #48575.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #48572 done by [Mergify](https://mergify.com). ## Why I'm doing: User can rely on this info to determin whether it's the right package to run on current host.

What I'm doing:

Add build arch info when showing FE/BE version.

# sh bin/show_fe_version.sh
...
Build arch: arm64
...

Tested on macOS, AWS graviton, and x86 ECS,
the corresponding values are: arm64, aarch64, x86_64.

Fixes #48575.

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: Dejun Xia <[email protected]>
@wanpengfei-git wanpengfei-git merged commit 020c699 into branch-3.1 Jul 19, 2024
27 of 30 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.1/pr-48572 branch July 19, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants