-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] count roaring bitmap memory usage in aggregator #49206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverbullet233
force-pushed
the
count_roaring_mem
branch
from
August 2, 2024 08:52
419a438
to
6dde134
Compare
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
This reverts commit 9c31a66. Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
count_roaring_mem
branch
from
August 5, 2024 02:11
6dde134
to
e51f34b
Compare
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
changed the title
[WIP][Enhancement] count roaring bitmap memory usage in aggregator
[Enhancement] count roaring bitmap memory usage in aggregator
Aug 5, 2024
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
count_roaring_mem
branch
from
August 6, 2024 02:01
4bc4f7f
to
ab7f81d
Compare
trueeyu
reviewed
Aug 6, 2024
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
trueeyu
reviewed
Aug 7, 2024
trueeyu
reviewed
Aug 7, 2024
Signed-off-by: silverbullet233 <[email protected]>
Signed-off-by: silverbullet233 <[email protected]>
silverbullet233
force-pushed
the
count_roaring_mem
branch
from
August 8, 2024 05:41
d5057d6
to
5253800
Compare
trueeyu
approved these changes
Aug 8, 2024
stdpain
approved these changes
Aug 8, 2024
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
[BE Incremental Coverage Report]❌ fail : 88 / 150 (58.67%) file detail
|
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
CountingAllocator
to count memory usage for specific modules.Aggregator
to count heap memory usage of agg states.AggregateStateAllocator
which is a STL-compitable Allocator. it will used by containers in different agg states to count memory. in this pr, I added it into distinct agg state to replace the original CountingAllocatorWhat type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: