Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix star count return null rather zero bug for mv rewrite #49288

Merged

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Aug 1, 2024

Why I'm doing:

  • count(*) returns null instead of zero after mv rewrite
    image

What I'm doing:

   // No needs to set `newProjections` since it will use aggColRefToAggMap to construct new projections,
      // otherwise it will cause duplicate projections(or wrong projections).
      // eg:
      // query: oldCol1 -> count()
      // newAggregations: newCol1 -> sum(oldCol1)
      // aggColRefToAggMap:  oldCol1 -> coalesce(newCol1, 0)
      // It will generate new projections as below:
      // newProjections: oldCol1 -> coalesce(newCol1, 0)

after:

 OUTPUT EXPRS:59: count
  PARTITION: RANDOM
  RESULT SINK
  3:Project
  |  <slot 59> : coalesce(80: count, 0)
  |  
  2:AGGREGATE (update finalize)
  |  output: sum(69: mock_062)
  |  group by: 
  |  
  1:Project
  |  <slot 69> : 69: mock_062
  |  
  0:OlapScanNode
     TABLE: tbl_mock_067
     PREAGGREGATION: ON
     partitions=1/120
     rollup: tbl_mock_067
     tabletRatio=1/1
     tabletList=12242
     cardinality=1
     avgRowSize=0.0
     MaterializedView: true

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@LiShuMing LiShuMing requested a review from a team as a code owner August 1, 2024 11:15
Seaven
Seaven previously approved these changes Aug 1, 2024
satanson
satanson previously approved these changes Aug 1, 2024
Signed-off-by: shuming.li <[email protected]>
@LiShuMing LiShuMing dismissed stale reviews from satanson and Seaven via 4e14cb0 August 1, 2024 12:02
Copy link

sonarcloud bot commented Aug 1, 2024

Copy link

github-actions bot commented Aug 2, 2024

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Aug 2, 2024

[FE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewRewriter.java 2 2 100.00% []

@LiShuMing LiShuMing enabled auto-merge (squash) August 2, 2024 05:59
@LiShuMing LiShuMing merged commit b5a9d75 into StarRocks:main Aug 2, 2024
50 checks passed
@LiShuMing LiShuMing deleted the fix/main/fix_mv_rewrite_count_star branch August 2, 2024 06:09
Copy link

github-actions bot commented Aug 2, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

@Mergifyio backport branch-3.2

Copy link

github-actions bot commented Aug 2, 2024

@Mergifyio backport branch-3.1

Copy link
Contributor

mergify bot commented Aug 2, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Aug 2, 2024

backport branch-3.2

✅ Backports have been created

Copy link
Contributor

mergify bot commented Aug 2, 2024

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 2, 2024
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
…49288)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit b5a9d75)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewRewriter.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayWithMVFromDumpTest.java
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
…49288)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit b5a9d75)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rule/transformation/materialization/AggregatedMaterializedViewRewriter.java
#	fe/fe-core/src/test/java/com/starrocks/sql/plan/ReplayWithMVFromDumpTest.java
LiShuMing added a commit that referenced this pull request Aug 4, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 4, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 5, 2024
wanpengfei-git pushed a commit that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants