Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix star count return null rather zero bug for mv rewrite (backport #49288) #49313

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 2, 2024

Why I'm doing:

  • count(*) returns null instead of zero after mv rewrite
    image

What I'm doing:

   // No needs to set `newProjections` since it will use aggColRefToAggMap to construct new projections,
      // otherwise it will cause duplicate projections(or wrong projections).
      // eg:
      // query: oldCol1 -> count()
      // newAggregations: newCol1 -> sum(oldCol1)
      // aggColRefToAggMap:  oldCol1 -> coalesce(newCol1, 0)
      // It will generate new projections as below:
      // newProjections: oldCol1 -> coalesce(newCol1, 0)

after:

 OUTPUT EXPRS:59: count
  PARTITION: RANDOM
  RESULT SINK
  3:Project
  |  <slot 59> : coalesce(80: count, 0)
  |  
  2:AGGREGATE (update finalize)
  |  output: sum(69: mock_062)
  |  group by: 
  |  
  1:Project
  |  <slot 69> : 69: mock_062
  |  
  0:OlapScanNode
     TABLE: tbl_mock_067
     PREAGGREGATION: ON
     partitions=1/120
     rollup: tbl_mock_067
     tabletRatio=1/1
     tabletList=12242
     cardinality=1
     avgRowSize=0.0
     MaterializedView: true

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #49288 done by [Mergify](https://mergify.com). ## Why I'm doing: - count(*) returns null instead of zero after mv rewrite ![image](https://github.com/user-attachments/assets/35ebc8f8-6475-4f29-a120-cd16c891418a)

What I'm doing:

   // No needs to set `newProjections` since it will use aggColRefToAggMap to construct new projections,
      // otherwise it will cause duplicate projections(or wrong projections).
      // eg:
      // query: oldCol1 -> count()
      // newAggregations: newCol1 -> sum(oldCol1)
      // aggColRefToAggMap:  oldCol1 -> coalesce(newCol1, 0)
      // It will generate new projections as below:
      // newProjections: oldCol1 -> coalesce(newCol1, 0)

after:

 OUTPUT EXPRS:59: count
  PARTITION: RANDOM
  RESULT SINK
  3:Project
  |  <slot 59> : coalesce(80: count, 0)
  |  
  2:AGGREGATE (update finalize)
  |  output: sum(69: mock_062)
  |  group by: 
  |  
  1:Project
  |  <slot 69> : 69: mock_062
  |  
  0:OlapScanNode
     TABLE: tbl_mock_067
     PREAGGREGATION: ON
     partitions=1/120
     rollup: tbl_mock_067
     tabletRatio=1/1
     tabletList=12242
     cardinality=1
     avgRowSize=0.0
     MaterializedView: true

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link

sonarcloud bot commented Aug 2, 2024

@wanpengfei-git wanpengfei-git merged commit 69ed21c into branch-3.3 Aug 8, 2024
41 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-49288 branch August 8, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants