Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Support const folding for replace() #49436

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[Enhancement] Support const folding for replace() #49436

merged 2 commits into from
Aug 7, 2024

Conversation

kaijianding
Copy link
Contributor

@kaijianding kaijianding commented Aug 6, 2024 •
edited
Loading

Why I'm doing:

pt >= replace ('2024-06-01', '-', '') and pt < replace ('2024-08-01', '-', '') can't trigger partition prune

What I'm doing:

add replace to scalar functions set to support replace const folding
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@kaijianding kaijianding requested a review from a team as a code owner August 6, 2024 08:58
@github-actions github-actions bot added the 3.3 label Aug 6, 2024
@kaijianding
fix ut
ef59d25 
Signed-off-by: kaijian.ding <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java 1 1 100.00% []

@Seaven Seaven merged commit b2436c7 into StarRocks:main Aug 7, 2024
56 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Aug 7, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 7, 2024 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 7, 2024
@kaijianding @mergify
[Enhancement] Support const folding for replace() (#49436)
fb29681 
Signed-off-by: kaijian.ding <[email protected]>
(cherry picked from commit b2436c7)
@mergify mergify bot mentioned this pull request Aug 7, 2024
Merged
32 tasks
@kaijianding kaijianding deleted the const_replace branch August 7, 2024 03:15
wanpengfei-git pushed a commit that referenced this pull request Aug 16, 2024
@mergify @kaijianding
[Enhancement] Support const folding for replace() (backport #49436) (#…
66a5e9d 
…49461)

Co-authored-by: kaijianding <[email protected]>
@murphyatwork
Copy link
Contributor

@Mergifyio backport branch-3.2

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 2, 2024 •
edited
Loading

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 2, 2024
@kaijianding @mergify
[Enhancement] Support const folding for replace() (#49436)
d2b751e 
Signed-off-by: kaijian.ding <[email protected]>
(cherry picked from commit b2436c7)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java
@mergify mergify bot mentioned this pull request Sep 2, 2024
Merged
32 tasks
murphyatwork pushed a commit that referenced this pull request Sep 2, 2024
@kaijianding @murphyatwork
[Enhancement] Support const folding for replace() (#49436)
d9a4918 
Signed-off-by: kaijian.ding <[email protected]>
(cherry picked from commit b2436c7)
wanpengfei-git pushed a commit that referenced this pull request Sep 3, 2024
@mergify @kaijianding
[Enhancement] Support const folding for replace() (backport #49436) (#…
db0387b 
…50572)

Co-authored-by: kaijianding <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@kangkaisen kangkaisen kangkaisen approved these changes

Assignees

@kaijianding kaijianding

Labels
3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaijianding @murphyatwork @Seaven @kangkaisen