Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support const folding for replace() (backport #49436) #50572

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 2, 2024

Why I'm doing:

pt >= replace ('2024-06-01', '-', '') and pt < replace ('2024-08-01', '-', '') can't trigger partition prune

What I'm doing:

add replace to scalar functions set to support replace const folding
Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #49436 done by [Mergify](https://mergify.com). ## Why I'm doing: `pt >= replace ('2024-06-01', '-', '') and pt < replace ('2024-08-01', '-', '')` can't trigger partition prune ## What I'm doing: add `replace` to scalar functions set to support `replace` const folding Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

@mergify mergify bot added the conflicts label Sep 2, 2024
Copy link
Contributor Author

mergify bot commented Sep 2, 2024

Cherry-pick of b2436c7 has failed:

On branch mergify/bp/branch-3.2/pr-49436
Your branch is up to date with 'origin/branch-3.2'.

You are currently cherry-picking commit b2436c7376.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctions.java
	modified:   fe/fe-core/src/test/java/com/starrocks/connector/parser/trino/TrinoFunctionTransformTest.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/sql/optimizer/rewrite/ScalarOperatorFunctionsTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Sep 2, 2024

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

@mergify mergify bot closed this Sep 2, 2024
Signed-off-by: kaijian.ding <[email protected]>
(cherry picked from commit b2436c7)
@mergify mergify bot deleted the mergify/bp/branch-3.2/pr-49436 branch September 2, 2024 11:57
@murphyatwork murphyatwork restored the mergify/bp/branch-3.2/pr-49436 branch September 2, 2024 11:57
@murphyatwork murphyatwork reopened this Sep 2, 2024
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) September 2, 2024 11:58
Copy link

sonarcloud bot commented Sep 2, 2024

@wanpengfei-git wanpengfei-git merged commit db0387b into branch-3.2 Sep 3, 2024
28 of 29 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.2/pr-49436 branch September 3, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants