[BugFix] fix column overflow when handle too large partial update (backport #49054) #49477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
In current implementation, when handle partial column update, we will try to build the column to be updated with segment granularity, it will lead to overflow. E.g.
ARRAY
column to be update, In the beginning, because the data in the table does not contain arrays yet, we will slice the segment file with a size of 1GB, so a segment file may contain a large number of rows. We can assume that there are 500w rows in a tablet.ArraryColumn
struct, we store offset of array using uint32_t , that means we can only have 4,294,967,295 items in aArraryColumn
.What I'm doing:
Processing updates involving large amounts of data in batches, each batch will be limit by
partial_update_memory_limit_per_worker
.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check:
This is an automatic backport of pull request #49054 done by [Mergify](https://mergify.com). ## Why I'm doing: In current implementation, when handle partial column update, we will try to build the column to be updated with segment granularity, it will lead to overflow. E.g. 1. If we have a `ARRAY` column to be update, In the beginning, because the data in the table does not contain arrays yet, we will slice the segment file with a size of 1GB, so a segment file may contain a large number of rows. We can assume that there are 500w rows in a tablet. 2. And in a `ArraryColumn` struct, we store offset of array using uint32_t , that means we can only have 4,294,967,295 items in a `ArraryColumn`. 3. When items in one array is larger than 900, which is large than 4,294,967,295, so overflow happens.
What I'm doing:
Processing updates involving large amounts of data in batches, each batch will be limit by
partial_update_memory_limit_per_worker
.What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist: